From: "Benno Lossin" <lossin@kernel.org>
To: "Lyude Paul" <lyude@redhat.com>, <rust-for-linux@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: "Andreas Hindborg" <a.hindborg@kernel.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
"FUJITA Tomonori" <fujita.tomonori@gmail.com>,
"Frederic Weisbecker" <frederic@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Anna-Maria Behnsen" <anna-maria@linutronix.de>,
"John Stultz" <jstultz@google.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>
Subject: Re: [PATCH v2 1/2] rust: time: Implement Add<Delta>/Sub<Delta> for Instant
Date: Fri, 08 Aug 2025 08:34:06 +0200 [thread overview]
Message-ID: <DBWU54JHWVNO.Y3EEXGS9TSSM@kernel.org> (raw)
In-Reply-To: <20250807190649.3078875-1-lyude@redhat.com>
On Thu Aug 7, 2025 at 9:06 PM CEST, Lyude Paul wrote:
> In order to maintain the invariants of Instant, we use saturating
> addition/subtraction that is clamped to the valid value range for a
> non-negative Ktime.
You're not using saturating operations in the patch?
---
Cheers,
Benno
> Signed-off-by: Lyude Paul <lyude@redhat.com>
>
> ---
> V2:
> * Change behavior in ops::{Add,Sub}<Delta> so that we panic on overflows
> under the same conditions that arithmetic operations in rust would panic
> by default.
> ---
> rust/kernel/time.rs | 43 ++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 42 insertions(+), 1 deletion(-)
prev parent reply other threads:[~2025-08-08 6:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-07 19:06 [PATCH v2 1/2] rust: time: Implement Add<Delta>/Sub<Delta> for Instant Lyude Paul
2025-08-07 19:06 ` [PATCH v2 2/2] rust: time: Implement basic arithmetic operations for Delta Lyude Paul
2025-08-08 6:42 ` Benno Lossin
2025-08-08 8:56 ` Alice Ryhl
2025-08-08 20:21 ` Benno Lossin
2025-08-08 9:26 ` Andreas Hindborg
2025-08-08 20:22 ` Benno Lossin
2025-08-10 7:18 ` Andreas Hindborg
2025-08-08 9:19 ` Andreas Hindborg
2025-08-08 22:44 ` Lyude Paul
2025-08-08 6:34 ` Benno Lossin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBWU54JHWVNO.Y3EEXGS9TSSM@kernel.org \
--to=lossin@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=anna-maria@linutronix.de \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=frederic@kernel.org \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.