Re: [PATCH v3 1/2] rust: add initial scatterlist abstraction

["Benno Lossin" <lossin@kernel.org>]

On Fri Aug 8, 2025 at 3:13 PM CEST, Andreas Hindborg wrote:
> "Abdiel Janulgue" <abdiel.janulgue@gmail.com> writes:
>> +    /// let mut pages = KVec::new();
>> +    /// let _ = pages.push(Page::alloc_page(GFP_KERNEL)?, GFP_KERNEL);
>> +    /// let _ = pages.push(Page::alloc_page(GFP_KERNEL)?, GFP_KERNEL);
>> +    /// let sgt = SGTable::new_owned(PagesArray(pages), GFP_KERNEL)?;
>> +    /// # Ok::<(), Error>(())
>> +    /// ```
>> +    pub fn new_owned(pages: P, flags: kernel::alloc::Flags) -> Result<Self> {
>> +        // SAFETY: `sgt` is not a reference.
>> +        let mut sgt: bindings::sg_table = unsafe { core::mem::zeroed() };
>
> I think this unsafe goes away with recent pin-init patches.
>
> https://lore.kernel.org/r/20250523145125.523275-1-lossin@kernel.org

Yes that should work. I'll send a new version when -rc1 comes out.

---
Cheers,
Benno