From: "Alexis Lothoré via buildroot" <buildroot@buildroot.org>
To: "Romain Naour" <romain.naour@smile.fr>, <buildroot@buildroot.org>
Cc: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Hervé Codina" <herve.codina@bootlin.com>,
"Nicolas Carrier" <nicolas.carrier@nav-timing.safrangroup.com>
Subject: Re: [Buildroot] [PATCH v2] package/php-lua: fix build with PHP8/GCC14
Date: Mon, 11 Aug 2025 07:24:07 +0200 [thread overview]
Message-ID: <DBZCJ6MUT01E.IED2BZIAW291@bootlin.com> (raw)
In-Reply-To: <e0045fd1-40e1-4af8-8031-9e051aff6833@smile.fr>
Hi Romain,
On Sat Aug 9, 2025 at 10:42 PM CEST, Romain Naour via buildroot wrote:
> Hello Alexis, All,
>
> Le 06/08/2025 à 22:42, Alexis Lothoré via buildroot a écrit :
[...]
>> diff --git a/package/php-lua/0003-php8-Signature-of-write-properly-read-property-was-changed.patch b/package/php-lua/0003-php8-Signature-of-write-properly-read-property-was-changed.patch
>> new file mode 100644
>> index 0000000000000000000000000000000000000000..0c68a7062451d40a2d630c24244ab003bdfb9396
>> --- /dev/null
>> +++ b/package/php-lua/0003-php8-Signature-of-write-properly-read-property-was-changed.patch
>> @@ -0,0 +1,77 @@
>> +From de1068d634519abf2461dac9427b5ff24b6603af Mon Sep 17 00:00:00 2001
>> +From: Mikhail Galanin <mikhail.galanin@team.bumble.com>
>> +Date: Tue, 24 Aug 2021 08:28:47 +0100
>> +Subject: [PATCH] php8: Signature of write_property/read_property was changed
>> + in https://github.com/php/php-src/commit/91ef4124e56
>> +
>> +Taken from https://github.com/badoo/php-lua/pull/8
>
> Check-package warn about missing "Upstream:" link.
>
> Since the patch come from a fork, using "Upstream" looks wrong here.
> Maybe Upstream: n/a ?
Sure, I can add this empty Upstream in the next revision.
Alexis
>
> Best regards,
> Romain
>
--
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2025-08-11 6:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-06 20:42 [Buildroot] [PATCH v2] package/php-lua: fix build with PHP8/GCC14 Alexis Lothoré via buildroot
2025-08-09 20:42 ` Romain Naour via buildroot
2025-08-11 5:24 ` Alexis Lothoré via buildroot [this message]
2025-08-13 10:43 ` Thomas Petazzoni via buildroot
2025-08-13 16:13 ` Alexis Lothoré via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBZCJ6MUT01E.IED2BZIAW291@bootlin.com \
--to=buildroot@buildroot.org \
--cc=alexis.lothore@bootlin.com \
--cc=herve.codina@bootlin.com \
--cc=nicolas.carrier@nav-timing.safrangroup.com \
--cc=romain.naour@smile.fr \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.