From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 253C678F54 for ; Tue, 12 Aug 2025 13:09:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755004153; cv=none; b=K9mIas4Tga7AdVhEY4FxDtJHLqFlbuBoPf6exH/DIOo69saEsoT3l6XCBlrAz3GrUFMZPwLAjHxs7ByE83mPTaRiBT4EyosiaXHl4tZKbV/SLgQnVsLXD0DMQIP3Q7Fsghc0CPNa8Tl8fp38W+kzw8bZY4S2Lu0NbbWxxrPds40= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755004153; c=relaxed/simple; bh=MAomTme2JM325tkXeqcrCAovhqZxr09aQ6wqQb8gykQ=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=f0wwDvC0oFSTmXU+ZaOdB2tOmNpSlDBNUNlEsbHcL1e4i3huG6goX8ZoRzCnoTRMdNbqi0v3tnUG6VhjhplPoY5tHr/tCU0kAbAdi4NiiE8cdGp1exJHtHdAObZ/SkDSwF1mBFvAi/DCZ/QNB4r7c/e+FgUU6owlflNo7b5ZgVw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com; spf=pass smtp.mailfrom=ventanamicro.com; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b=Q60uJaTs; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="Q60uJaTs" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3b9139aa446so34235f8f.0 for ; Tue, 12 Aug 2025 06:09:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1755004150; x=1755608950; darn=vger.kernel.org; h=in-reply-to:references:from:to:cc:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MAomTme2JM325tkXeqcrCAovhqZxr09aQ6wqQb8gykQ=; b=Q60uJaTsOOF5ebIfW/00Rg/iFfp/UJrgpzi7fKjwp6OTaKkDLybCBw0oecXEA//Rp+ OEhGcYLbgYkbIM3Jqdd4mWxKCBxkFpCG1laSD0Ws++cxWdon7EBiOWhUdlOpynHq+MJw FW1Xadq1WVL9LjDYEeJdAftoZBH5to/rZTxpgeifgSEqvdaOJC/yjeZpGUk48lB4IVbR BAEEnH7+gqXVnBBjJ4kOMSk4X34BVW79dYiOzTs+TxWDT5PeiZUfU8nDacTUFgmgsTta getoB0iBHzEY7ytHu6DFxcWuzzNNpccBdWZyeffW5MZEt4YlhZG3RpisIgbexcViP4oo lLiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755004150; x=1755608950; h=in-reply-to:references:from:to:cc:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=MAomTme2JM325tkXeqcrCAovhqZxr09aQ6wqQb8gykQ=; b=IvedcahZ2aoS2/kHWV03PbX8oYC0M3EKczsng4BKVvXtPEqQldobg5CuPgVuXc18xJ +RcW6520YTRCO5zlgG6V1rP9tcD5c7itN2JxM1iU3z079qQNvAL7RLgA9oxOg+KLVqdS yxE4AtpSn6z6bmRmYctR0jEz6VCG2ne/2HQqdU5Ut5kg2b1/DZpc33J7RK/OTO/OGyXC lXfYm+BPFNHuG8OmJyVawAzTRrNTGhyAvf+Iz4VQB8Exdm2BNDxPPdYbjcG/AO5jOhHU 7lQsH/Z9WMchNjjDyDLeVdp8VKtCJoCePMbzcLx2laE5toiXBiWwqFIkSt33Iz60f3SJ queg== X-Forwarded-Encrypted: i=1; AJvYcCXA2awBdsqw5aTdKHoObYYab8v0x+mIgXCoarkw2Px2uIHKIbD9T+yzWlFqovFdPhtj1X0=@vger.kernel.org X-Gm-Message-State: AOJu0YxN5x/3OB3xGz+4tVDagVuYdVI5FLR1htMqD20rI1VAia638B1M 6ynD7OoIiwZH2eN6qdwB5BWgUUxi2ojGas62Nv5h+GHVxxFSFESFLJAcba8LwzrzSTU= X-Gm-Gg: ASbGncuNQVMJpIl5wZq3OxWTMq3HKdFgoo2vyegNWlHUuSyy7ofcN4EGlIGyEW9nXcw 4tNTYTXJYzANoS1v0sBtIp6Lx5Q3m0j9BwXDqyivG43/7eXgkHMBGo509jVJ9ZOJ6J0mVfJyP4b hrZsLYnbqSqvCGcxaPKd9Xn2mrZLUb95+h345IAKP7pIJP/tVHUJr0OeqKaiuUi0GZSZRx179sS TXCwskVTP3JFgZP73n2332uUxq2ZZjwreqn60h7ZC35yq6RRNvtClpFutQldsAypMFzse6vydYx Rea6KRizKvGnnxXOThYA+i0HNY31L4EkK1LOEojkM/+LHkKKxOqYytqnNh1sqbCwKAPcN2BTPz6 YuS1sg6Phb2i2qZQeUhWRjZ6CE5SRJw== X-Google-Smtp-Source: AGHT+IFCL0S2fG+7EvsWvlnJgkjJOc9wFOS6dc1oCWSwvbA7urqknr0ZeJjmy9NTqLN0RG30vSqL/A== X-Received: by 2002:a05:6000:1785:b0:3b7:948a:137b with SMTP id ffacd0b85a97d-3b9147c2a32mr526638f8f.11.1755004150288; Tue, 12 Aug 2025 06:09:10 -0700 (PDT) Received: from localhost ([2a02:8308:a00c:e200:8113:2b11:8f42:672f]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3b79c338c7dsm44458535f8f.0.2025.08.12.06.09.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Aug 2025 06:09:09 -0700 (PDT) Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 12 Aug 2025 15:09:09 +0200 Message-Id: Subject: Re: [PATCH 0/2] riscv, bpf: fix reads of thread_info.cpu Cc: "Alexei Starovoitov" , "Daniel Borkmann" , "Andrii Nakryiko" , "Martin KaFai Lau" , "Eduard Zingerman" , "Song Liu" , "Yonghong Song" , "John Fastabend" , "KP Singh" , "Stanislav Fomichev" , "Hao Luo" , "Jiri Olsa" , =?utf-8?q?Bj=C3=B6rn_T=C3=B6pel?= , "Pu Lehui" , "Puranjay Mohan" , "Paul Walmsley" , "Palmer Dabbelt" , "Albert Ou" , "Kumar Kartikeya Dwivedi" , , To: "Alexandre Ghiti" , From: =?utf-8?q?Radim_Kr=C4=8Dm=C3=A1=C5=99?= References: <20250812090256.757273-2-rkrcmar@ventanamicro.com> <1fdaa939-d26c-454a-a722-7d0a590557b7@ghiti.fr> In-Reply-To: <1fdaa939-d26c-454a-a722-7d0a590557b7@ghiti.fr> 2025-08-12T13:37:16+02:00, Alexandre Ghiti : > @Radim: This is the third similar bug, did you check all assembly code=20 > (and bpf) to make sure we don't have anymore left or should I? I looked at load/store instructions, including bpf, and focussed on patterns where we access non-xlen sized data through an offset. (Nothing else popped up, but I mostly used grep and cscope as I don't know of any semantic tool, so my confidence levels are low.) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC5D4CA0EE0 for ; Tue, 12 Aug 2025 16:30:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:From:To:Cc: Subject:Message-Id:Date:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tq5uZrLqQWbFlaWsH2NXNVK7Dg3iW9wkIBsa8p++j98=; b=NGX0yYE0GfOgiU YqK/aUTpTRADrz/LpLkdQuduwXAU0HLTTi0Dl/4Y1nE434DK1ZQgMSo+Yk2aX1VeH68BifEbvZxv+ 7O3Rq1K9Wlp36TxbBz0JoMvqgciin2B7g7xEx2S3DZMZTz3ewRxRzCu9Q8g2wE6C+qUrTJ3fbN0D2 y4K1EuadcOVLVtaTuRdleMF85eD0Q7C09a3gaFVurzA1hmmnfDZWouLlXKK/YEfecRxTHTl+fZJAV GF9pFhtiKupnwwinm4EGE/ZXnFNf41c5EIs8qcqA+8Ysvhj1axJjAa6tlQ0X5W39F33EVUrowa8T6 jOWIX2TEe/sAueQOg9vg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ulrtf-0000000BQ3x-2ajR; Tue, 12 Aug 2025 16:30:47 +0000 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uloka-0000000AsLl-0Fje for linux-riscv@lists.infradead.org; Tue, 12 Aug 2025 13:09:13 +0000 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-3b788fdcc2dso389785f8f.1 for ; Tue, 12 Aug 2025 06:09:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1755004150; x=1755608950; darn=lists.infradead.org; h=in-reply-to:references:from:to:cc:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=MAomTme2JM325tkXeqcrCAovhqZxr09aQ6wqQb8gykQ=; b=LlCvLaXBV7TAYbpOc1M41g1PS059OiBIuknU9VYCgkEws+UEjkJXmrSk449g8uCZkU ase+PJkHYb97MgiQZ+1nupmOjrsLpTB4BIlTyaNGFZTutuC/vnBEk1xEkJ97z5wH9fo+ BY5whyVEhTGVUL2MJ6j+Y7dlMCmlIiUvT0N9jwAUxikN4PZd+DO6zEtTzC2fQ5X0Yi5Q dsboDMMRSsgoTZGKLxV6du00aLV1uK58H0GqrfKhSKvMMGefz4b5iezIUnoTgWNw3sjc cGfR8Lh2msxHEmJUOEaqZnMV28fdNm3K/qFzzieljdy/4dQgX4xS0qPNLjj7k19Nd52y yMLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755004150; x=1755608950; h=in-reply-to:references:from:to:cc:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=MAomTme2JM325tkXeqcrCAovhqZxr09aQ6wqQb8gykQ=; b=D7b3vs7vgVVzWqTW9ovo5crMnO7uvt5w4v4Co20pasbukQnf290WGYDNu9DpJsQ+jz ktXynJrZZ5ofWaYak1Nal5vKlB+7GRPmuFZlkQOPDzYfHCPh4Hu8lGG9rpEz+setBcOx rNFKSJo2djOTI5s5GeGNOnzd5wlrtFR4X/UeBWQdsH6IQEg1LrPM4HJymC0ImGXa8gd4 RQp/pw98nCDIOsm8AnvZzqY4pFwgM6Gb1Bk0IAZd26extG7huINKZV/FTlMrQy79FWFA wH9ti5LSKGTH20G8C9oXYbuC02NDObfx9cXny3c1Za36JewdAvGLJ+1mB5GYddr1HnSn KIAA== X-Forwarded-Encrypted: i=1; AJvYcCXioORXfqEvki8j0oG4sqLKoaONnpALdj4I0y1i2GtcjMQTUJiQB1okNmvmu5Pj2jgvD5d0eK6mPSb2Sg==@lists.infradead.org X-Gm-Message-State: AOJu0YyqX4Fb5yEu/kFkAU6XSzBCVbyMYkgsKEQ871ZY44ObeuM9KJ9H ZOdO50KNomtKrumw8Q17FpoYpegfaTS0EsO+xQGKv8m2Z74sgVKkrxtE+o5oJlqcqRFvQRjcDEm cw7pY X-Gm-Gg: ASbGnctDj+8tTEbshgU0S0Wd/tYqtCiND0XGN4zBOfzvI09qJZF9C84NWzBg3D1MVEr SYkFm5mxy0mTrxZucylgOZNl2tYqR7g5fdJg+HYVBsyxK1WnmkByYU/njCkHXFsnRGec+yzTwbI 2g3SfnSxh3LXLgozD3GkdFpHMOyjkDE6JV/ukfvU9SN28yrJQPANBARRH46PAlfLKumcLGBA0Ed AEh3Eqct3+NK3L8pb3T+E+lgLtdmyu/Qe/X7rnyuHzu8oQyBuQ9enC3IWsLWmJzrOHq7GnhwlTK j7roAn14cYEpLKTp7O7wPi04F5kTF/mrBKHLOkEltNe1s27zU2Iu0k03PTATIB2b6ADCYRbHfeJ LC8WA3cQsd4t6ANpYZeB1n1PpAaSNMQ== X-Google-Smtp-Source: AGHT+IFCL0S2fG+7EvsWvlnJgkjJOc9wFOS6dc1oCWSwvbA7urqknr0ZeJjmy9NTqLN0RG30vSqL/A== X-Received: by 2002:a05:6000:1785:b0:3b7:948a:137b with SMTP id ffacd0b85a97d-3b9147c2a32mr526638f8f.11.1755004150288; Tue, 12 Aug 2025 06:09:10 -0700 (PDT) Received: from localhost ([2a02:8308:a00c:e200:8113:2b11:8f42:672f]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3b79c338c7dsm44458535f8f.0.2025.08.12.06.09.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Aug 2025 06:09:09 -0700 (PDT) Mime-Version: 1.0 Date: Tue, 12 Aug 2025 15:09:09 +0200 Message-Id: Subject: Re: [PATCH 0/2] riscv, bpf: fix reads of thread_info.cpu Cc: "Alexei Starovoitov" , "Daniel Borkmann" , "Andrii Nakryiko" , "Martin KaFai Lau" , "Eduard Zingerman" , "Song Liu" , "Yonghong Song" , "John Fastabend" , "KP Singh" , "Stanislav Fomichev" , "Hao Luo" , "Jiri Olsa" , =?utf-8?q?Bj=C3=B6rn_T=C3=B6pel?= , "Pu Lehui" , "Puranjay Mohan" , "Paul Walmsley" , "Palmer Dabbelt" , "Albert Ou" , "Kumar Kartikeya Dwivedi" , , To: "Alexandre Ghiti" , From: =?utf-8?q?Radim_Kr=C4=8Dm=C3=A1=C5=99?= References: <20250812090256.757273-2-rkrcmar@ventanamicro.com> <1fdaa939-d26c-454a-a722-7d0a590557b7@ghiti.fr> In-Reply-To: <1fdaa939-d26c-454a-a722-7d0a590557b7@ghiti.fr> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250812_060912_097358_642CA056 X-CRM114-Status: UNSURE ( 5.76 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org 2025-08-12T13:37:16+02:00, Alexandre Ghiti : > @Radim: This is the third similar bug, did you check all assembly code > (and bpf) to make sure we don't have anymore left or should I? I looked at load/store instructions, including bpf, and focussed on patterns where we access non-xlen sized data through an offset. (Nothing else popped up, but I mostly used grep and cscope as I don't know of any semantic tool, so my confidence levels are low.) _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv