From: "Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>
To: <pierre-loup.gosse@smile.fr>, <openembedded-core@lists.openembedded.org>
Cc: "Alexander Kanavin" <alex.kanavin@gmail.com>
Subject: Re: [PATCH v3 1/2] wic: add --extra-partition-space option to set unused space
Date: Tue, 12 Aug 2025 16:17:29 +0200 [thread overview]
Message-ID: <DC0II3M8AROA.WDDDZHO2OW9D@bootlin.com> (raw)
In-Reply-To: <20250811134804.841937-1-pierre-loup.gosse@smile.fr>
On Mon Aug 11, 2025 at 3:48 PM CEST, pierre-loup.gosse wrote:
> From: Pierre-Loup GOSSE <pierre-loup.gosse@smile.fr>
>
> By default, the content of the partition is filled by the filesystem
> without leaving any unused free space. The --extra-space flag adds
> extra space to the filesystem size, not to the partition.
>
> Unused free space after the filesystem can be useful for some cases,
> such as encrypting a partition at runtime.
> With --extra-partition-space 32M, we ensure that the last 32M of the
> partition is unused: this space does not contain filesystem data and
> can store the LUKS2 header.
>
> The implementation sets a difference between the partition and
> filesystem size:
> - With --fixed-size, the extra part space is removed from the
> filesystem size.
> - Otherwise (with or without --size flag), the extra part space is
> added to the partition size.
>
> Signed-off-by: Pierre-Loup GOSSE <pierre-loup.gosse@smile.fr>
>
> CC: Alexander Kanavin <alex.kanavin@gmail.com>
> CC: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
> ---
Hi Pierre-Loup,
Thanks for the new version.
It looks like some of the tests are failing on the autobuilder:
2025-08-12 11:56:06,941 - oe-selftest - INFO - 9: 73/92 537/635 (83.03s) (0 failed) (wic.Wic2.test_extra_partition_space)
2025-08-12 11:56:06,941 - oe-selftest - INFO - testtools.testresult.real._StringException: Traceback (most recent call last):
File "/srv/pokybuild/yocto-worker/oe-selftest-armhost/build/meta/lib/oeqa/selftest/cases/wic.py", line 1375, in test_extra_partition_space
self.assertNotEqual(p.status, 0, "wic exited successfully when an error was expected:\n%s" % p.output)
File "/usr/lib/python3.12/unittest/case.py", line 894, in assertNotEqual
raise self.failureException(msg)
AssertionError: 0 == 0 : wic exited successfully when an error was expected:
...
2025-08-12 12:40:46,950 - oe-selftest - INFO - FAIL: wic.Wic2.test_extra_partition_space (subunit.RemotedTestCase)
https://autobuilder.yoctoproject.org/valkyrie/#/builders/23/builds/2285
https://autobuilder.yoctoproject.org/valkyrie/#/builders/35/builds/2135
https://autobuilder.yoctoproject.org/valkyrie/#/builders/48/builds/2064
Can you have a look at the issue please?
--
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2025-08-12 14:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 13:48 [PATCH v3 1/2] wic: add --extra-partition-space option to set unused space pierre-loup.gosse
2025-08-11 13:48 ` [PATCH v3 2/2] wic: rename wks flag --extra-space to --extra-filesystem-space pierre-loup.gosse
2025-08-11 16:07 ` [OE-core] " Quentin Schulz
2025-08-12 7:11 ` pierre-loup.gosse
2025-08-11 13:59 ` [PATCH v3 1/2] wic: add --extra-partition-space option to set unused space pierre-loup.gosse
2025-08-12 14:17 ` Mathieu Dubois-Briand [this message]
2025-08-14 12:20 ` pierre-loup.gosse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DC0II3M8AROA.WDDDZHO2OW9D@bootlin.com \
--to=mathieu.dubois-briand@bootlin.com \
--cc=alex.kanavin@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=pierre-loup.gosse@smile.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.