From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99A67CA0EDC for ; Tue, 12 Aug 2025 16:51:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5F72610E176; Tue, 12 Aug 2025 16:51:19 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="XbUHCNGU"; dkim-atps=neutral Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by gabe.freedesktop.org (Postfix) with ESMTPS id F2FB110E61C; Tue, 12 Aug 2025 16:51:17 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 6DCF8A57737; Tue, 12 Aug 2025 16:51:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BBE0C4CEF0; Tue, 12 Aug 2025 16:51:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755017476; bh=nKoG5s9KE5VuYOww9nWFvxIiz2+ngkmQWq3/VFPjcOs=; h=Date:From:Subject:Cc:To:References:In-Reply-To:From; b=XbUHCNGU+yoat9PLyUb6JCiitWvNxnEmybXW3iAbGdWKd0EQgfRzggDWQcz04yFeu meStvHN6QLRALvX85L9cbiDvFoMmEvcdMKnL+8qOSl/x6wRf6KPht23ahvXgI6cspa PlVpqOjV885/q9hq1bIlVrMcunIksPq5xcx87wvZqPZ7QNVPvLD7hdReOc21sG+SKg o/j4bd0+MhhCinPttaOhKRUSSx5aOMNNED2ei7DXzXLmSfOYtfJ/8uw4kzJudYbu8z PqpcJNF09qeU/ewfXUuTkQas3DnwsdKgNvMbETQHEKG9rGpoa5tjwxKJG9W2L3Ohp4 MWyC53cFFGc2g== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Tue, 12 Aug 2025 18:51:12 +0200 Message-Id: From: "Danilo Krummrich" Subject: Re: [PATCH v6 01/26] drm/gpuvm: Pass map arguments through a struct Cc: , "Matthew Brost" , =?utf-8?q?Thomas_Hellstr=C3=B6m?= , "Boris Brezillon" , "Brendan King" , "Boris Brezillon" , "Caterina Shablia" , "Rob Clark" , To: "Himal Prasad Ghimiray" References: <20250807164338.1832254-1-himal.prasad.ghimiray@intel.com> <20250807164338.1832254-2-himal.prasad.ghimiray@intel.com> In-Reply-To: <20250807164338.1832254-2-himal.prasad.ghimiray@intel.com> X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Thu Aug 7, 2025 at 6:43 PM CEST, Himal Prasad Ghimiray wrote: > @@ -2102,17 +2106,16 @@ op_unmap_cb(const struct drm_gpuvm_ops *fn, void = *priv, > static int > __drm_gpuvm_sm_map(struct drm_gpuvm *gpuvm, > const struct drm_gpuvm_ops *ops, void *priv, > - u64 req_addr, u64 req_range, > - struct drm_gem_object *req_obj, u64 req_offset) > + const struct drm_gpuvm_map_req *req) > { > struct drm_gpuva *va, *next; > - u64 req_end =3D req_addr + req_range; > + u64 req_end =3D req->op_map.va.addr + req->op_map.va.range; Forgot to add, please extract all previous values from req, such that the b= elow diff is minimal and the code remiains easier to read..