From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C17EC3115BD for ; Tue, 19 Aug 2025 08:29:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755592161; cv=none; b=L5Ok/MRGoUxePbuETZ/BEvYaHR7pYWjZKBRAcAn7L1vZ6VKCzdbkF0vSovye2zfq6WNdPXOvxyfga4glCZAvb92wUV9w0BufTJnuqNh+Mce4TwAGJG1250SI2W34Wjyr5lpZQbWCF7rQn4cTc660ij1/roForCujj4Ct0ytimXQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755592161; c=relaxed/simple; bh=wM9xXC+D294Q3NUdde5c9ksE9RETsJFMNAGdmuAyQLA=; h=Mime-Version:Content-Type:Date:Message-Id:To:Cc:Subject:From: References:In-Reply-To; b=hJ/X2IyuaCU7tdQeeA1+Jxo71ORow9WfCH1rst7SIPnKr4tY32e9b6ZRYHPhvUz195nCYLy4/jbp1g0i8ofOh/Kl5i8eyEAUJouvy+nG+51FFdYc8tUSB5H6rzWOY68TC0zgCD5LwQmzGTSyPKe0SpQMqv6WVk6rMNFC3qKreho= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=DA/HfZBB; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="DA/HfZBB" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-afcb61f6044so837486066b.0 for ; Tue, 19 Aug 2025 01:29:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1755592156; x=1756196956; darn=vger.kernel.org; h=in-reply-to:references:from:subject:cc:to:message-id:date :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=TCI9o6Ocmammodx0PX+9MIbgr0tFJH9KqExrAza1lZA=; b=DA/HfZBB5gN8xVgBBJCfet2WqbDHktgESdTtS3HN8YTz+5l0o/541QYyEPUDcTvRnj +kRUu/UQIRxBVgI/AyctXq+bjkE9GV6xbUd/vNY92B8JNOUc9DNYu5S0j5rgI2DU/ddT uWWQlRgEsil/fRUS8r+a7qhkLcpQpdEziAkjs9nFn6l55rFw4UEiY6OnHIVnb7UlT//Y Jt93eFyffEReKCCd2i9ypqlNxjZ2ZMa0rJxiMbehxVZJKqYpmburhMacf7G5n9hd7k8Z /dIdkvRonaZHOCfZ3ERfvoVLeb4wKWQSTSALD4Cs6+I0uxEx20wMTwTVQkXtWQtohzh2 gwfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755592156; x=1756196956; h=in-reply-to:references:from:subject:cc:to:message-id:date :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TCI9o6Ocmammodx0PX+9MIbgr0tFJH9KqExrAza1lZA=; b=Q9oUdjV3rKgiIDiSv4lykhWXDxqGsOjBp5nO9x7wEPvgjo5SZMGn/StFVOfg2kqI/q chKef9ND7/x9Qh2z3wRCesMirytROQKVL93g0UnJNbt8P7dVpjpkPaP9akhTjKCBxKG0 HiR3cQtcwcCqwEY5LYKT2T1N7ASqX6LXlvJV50o5Y+EsqiIYiSYCtqGCP08oc5L1Doaq vim+Y1KbPxUJAnegFQBo5QBLFlRNshX/H+PwUUww1TCWCrHSUtwhL3VwyBwSPr3Co9aa vy5UuazFmQzaztJ3w1Afy/d+BzKiCvgnUCRD6D8hEZdgD0o9sdkDJRWuo6nvyANMNnTK kYcw== X-Gm-Message-State: AOJu0YyaAn/go9LFk6fpnkYP2oMtVrvv7gjmzio8e0lF+Lp8O9XpMAVR bZvyAgK1ol6kqY+kqDmh+W1XELCfcqTeZ1BWuaobKYMnOkX+c9oJXmR2R2taT9+Lr8E= X-Gm-Gg: ASbGncufJJaHYOPtV6MNqaUNqNTsRQwOjpBtKfe98dJwwqD52pFDx/Lj/popw8jf3cW Sf8nawRQeHgWtxgGFoehYNt7DCWuwiDl6YmD4ErB2NmClOzkPSlNEcf+19oXFQYKlRkTtVaantS Ri+JhdYzLLe/rYpJ0Yq5xL9Rg04JwpfopZxKMx99UOz1ootbY9iF7Qy0eSHJKFXN1zX8OXTQpPe kopdGPU/jjwHnO20GW3cmXW/43kxAQpqz+Ysvgi7Z6rbZJrcxH9NCJ24NMqtFUd5fLg1yjrF3x5 O9Xe3sPk4b5oSFSsfm1j8cevy4l657msp5cyix6LLmQiM5ntyhXdM+C5o8yZBvwz8S7V3EsT+hP 7ow9zsNG+8x/aUg== X-Google-Smtp-Source: AGHT+IEpf0xkM4Fy64K7iYsZpzlLtHAWLLw9UAj4WJRT9U5fr7fAn7CUDHHuzyYNHqv1utE6AIxlJw== X-Received: by 2002:a17:907:9807:b0:af9:41a4:25b3 with SMTP id a640c23a62f3a-afdded8e7f6mr142953466b.29.1755592156089; Tue, 19 Aug 2025 01:29:16 -0700 (PDT) Received: from localhost ([195.52.61.108]) by smtp.gmail.com with UTF8SMTPSA id 4fb4d7f45d1cf-61a75794ba2sm1329676a12.45.2025.08.19.01.29.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Aug 2025 01:29:15 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-can@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: multipart/signed; boundary=6d44b553a7c7e2e2a2c9164fc3dbefb8444bd5baec51a0f82cba40b40ec1; micalg=pgp-sha512; protocol="application/pgp-signature" Date: Tue, 19 Aug 2025 10:29:09 +0200 Message-Id: To: "Marc Kleine-Budde" , "Chandrasekar Ramakrishnan" , "Vincent Mailhol" , "Patrik Flykt" , "Dong Aisheng" , "Fengguang Wu" , "Varka Bhadram" , "Wu Bo" , "Philipp Zabel" Cc: , , Subject: Re: [PATCH 2/7] can: m_can: m_can_rx_handler(): only handle active interrupts From: "Markus Schneider-Pargmann" X-Mailer: aerc 0.20.1 References: <20250812-m_can-fix-state-handling-v1-0-b739e06c0a3b@pengutronix.de> <20250812-m_can-fix-state-handling-v1-2-b739e06c0a3b@pengutronix.de> In-Reply-To: <20250812-m_can-fix-state-handling-v1-2-b739e06c0a3b@pengutronix.de> --6d44b553a7c7e2e2a2c9164fc3dbefb8444bd5baec51a0f82cba40b40ec1 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Tue Aug 12, 2025 at 7:36 PM CEST, Marc Kleine-Budde wrote: > Among other things, the M_CAN IP core has an Interrupt Register (IR) > and an Interrupt Enable (IE) register. An interrupt is triggered if at > least 1 bit is set in the bitwise and of IR and IE. > > Depending on the configuration not all interrupts are enabled in the > IE register. However the m_can_rx_handler() IRQ handler looks at all > interrupts not just the enabled ones. This may lead to handling of not > activated interrupts. But isn't that happening for m_can_interrupt_handler() in general then? Best Markus > > Fix the problem and mask the irqstatus (IR register) with the > active_interrupts (cache value of IE register). > > Fixes: e0d1f4816f2a ("can: m_can: add Bosch M_CAN controller support") > Signed-off-by: Marc Kleine-Budde > --- > drivers/net/can/m_can/m_can.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.= c > index fe74dbd2c966..a51dc0bb8124 100644 > --- a/drivers/net/can/m_can/m_can.c > +++ b/drivers/net/can/m_can/m_can.c > @@ -1006,6 +1006,7 @@ static int m_can_rx_handler(struct net_device *dev,= int quota, u32 irqstatus) > int rx_work_or_err; > int work_done =3D 0; > =20 > + irqstatus &=3D cdev->active_interrupts; > if (!irqstatus) > goto end; > =20 --6d44b553a7c7e2e2a2c9164fc3dbefb8444bd5baec51a0f82cba40b40ec1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iKMEABYKAEsWIQSJYVVm/x+5xmOiprOFwVZpkBVKUwUCaKQ11RsUgAAAAAAEAA5t YW51MiwyLjUrMS4xMSwyLDIRHG1zcEBiYXlsaWJyZS5jb20ACgkQhcFWaZAVSlNB 7wD/cIXNFNL3XdWS815Jyw2Qf29KhK0qlWvUInVXRI9txwQA/0Jwxk5x8pj4Cwaj bAJFDc2KKCrNe8rgxRBKzRgVU9oI =unW3 -----END PGP SIGNATURE----- --6d44b553a7c7e2e2a2c9164fc3dbefb8444bd5baec51a0f82cba40b40ec1--