Re: [PATCH v4 4/7] rust: page: define trait AsPageIter

["Danilo Krummrich" <dakr@kernel.org>]

On Tue Aug 19, 2025 at 3:08 PM CEST, Daniel Almeida wrote:
>> On 14 Aug 2025, at 06:33, Danilo Krummrich <dakr@kernel.org> wrote:
>> +/// [`BorrowedPage`] items, such as [`VmallocPageIter`](kernel::alloc::allocator::VmallocPageIter).
>> +pub trait AsPageIter {
>> +    /// The [`Iterator`] type, e.g. [`VmallocPageIter`](kernel::alloc::allocator::VmallocPageIter).
>> +    type Iter<'a>: Iterator<Item = BorrowedPage<'a>>
>> +    where
>> +        Self: 'a;
>> +
>> +    /// Returns an [`Iterator`] of [`BorrowedPage`] items over all pages owned by `self`.
>> +    fn page_iter(&mut self) -> Self::Iter<'_>;
>
> Does it make sense to break this into page_iter() and page_iter_mut()?
> Alternatively, should this take &self instead?

The Iterator relies on the underlying data structure not being altered. For
instance, a VVec giving out a VmallocPageIter must not be re-allocated while the
VmallocPageIter exists.