From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EDFD9CA0EDC for ; Wed, 20 Aug 2025 12:04:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B3B8610E140; Wed, 20 Aug 2025 12:04:57 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="fdkjwDr5"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7F08510E140; Wed, 20 Aug 2025 12:04:56 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id A241C61430; Wed, 20 Aug 2025 12:04:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9874FC4CEEB; Wed, 20 Aug 2025 12:04:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755691495; bh=/E8c7V580I2/gRQqUxnFdTkr3E+gxiO982o6bFa1zlU=; h=Date:Subject:Cc:To:From:References:In-Reply-To:From; b=fdkjwDr5xn3aIoF6fl+/JE9+7/sZqDq82WXMkHlAPNiazHV4p+x+5dInAs7UwI6kM A7+/Ghd8GvxyQhTMHHpsnJ42dEaKx3PwYnYKD2LMcz5aWTp3FaBf4tNaN+j3vpZaDL KfYhuKDdFd8RPhYxYseZa37bZPp2+STZI9Sw9PwZaa2j3nMhVM2WCUDunDe0GD0O/z X+BKL5T3EFJaRmNnBOZ1DDciiJkMtn0tzYPac/yrdr8BVG2mN0CKtVxvDC5Q5Ylu05 aF66jl9M5OzU3MrWxsf3Tn3pt9DmqXZm+zg+z1iRfkimAhnrJk/M0hNZbYM1Y5BqsI f2ZbyiW8ZEoqw== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 20 Aug 2025 14:04:51 +0200 Message-Id: Subject: Re: [PATCH v8 01/24] drm/gpuvm: Pass map arguments through a struct Cc: "Himal Prasad Ghimiray" , , , "Brendan King" , "Matt Coster" , "Boris Brezillon" , "Caterina Shablia" , "Rob Clark" , "Matthew Brost" To: "Boris Brezillon" From: "Danilo Krummrich" References: <20250818215753.2762426-1-himal.prasad.ghimiray@intel.com> <20250818215753.2762426-2-himal.prasad.ghimiray@intel.com> <20250820135657.19a6bcbc@fedora> In-Reply-To: <20250820135657.19a6bcbc@fedora> X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed Aug 20, 2025 at 1:56 PM CEST, Boris Brezillon wrote: > On Tue, 19 Aug 2025 03:27:30 +0530 > Himal Prasad Ghimiray wrote: >> +/** >> + * struct drm_gpuvm_map_req - arguments passed to drm_gpuvm_sm_map[_ops= _create]() >> + */ >> +struct drm_gpuvm_map_req { >> + /** >> + * @op_map: struct drm_gpuva_op_map > > Doc name doesn't match the field name. > >> + */ >> + struct drm_gpuva_op_map map; > > Nit: not convinced map is a good name for that field, given this is a > map_req, so we now those are map-related arguments. I would probably > go for 'op'. Indeed, thanks for catching this! I thought I was suggesting this name in a previous version too.