From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01C9621ABB0; Wed, 20 Aug 2025 12:56:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755694619; cv=none; b=nvcHGymKRpeQX+29CoufUhamoY74MekDBfTQNk/bY65DdMjDNELTjW/kB+3Uy8ZY7o2VZ5HvypnXJRNNDbZxzYWViH16fOVmGPc6JY7IRrjb26GnvoT9ffbG0UlLUHHwiMy1TUEKWGgCeLo8Gz9+Ry3sV37JmymHkP4vYVjIRNo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755694619; c=relaxed/simple; bh=WUtS7YH/SFTY41jyLTuZUHacFQDyALN4XUUiWqnxkf0=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=ZK+rm4nvGAPS+eej94MD6QvRjfqVDttAGEzw05lQ4OlGO7e5rqkI8XyDe9dWoOt29bTUeeja7jk4L+UObjdXmapxMkRXdtAx2JmPBcrKRsvYiJSYX2SjGSLbmuPNumA4QfsRI+s0xijaptTEsLVq3IyTAVT/5DSCbdhGH3Zq2BA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uBQfWlXE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uBQfWlXE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64EB6C4CEEB; Wed, 20 Aug 2025 12:56:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755694617; bh=WUtS7YH/SFTY41jyLTuZUHacFQDyALN4XUUiWqnxkf0=; h=Date:Subject:Cc:To:From:References:In-Reply-To:From; b=uBQfWlXE6egP51AfpugeaQe+SRkMjqQaTFBS08ZywfPjrF2ejzmvwEvs6wLFBj+Iv cKynCShXKVxGNHaslpmbD8mq9Q//X/eXIcouF/4iHgK9Bo2V+XmCwlVTj6B3DHHCP4 YOsfgu5Hoi30iGRZZpYbwsOqNcHeKPNg67BEn3BcSUNyTq0tCIu/bqnMLQMTddeumP OIZqcgRzqcEswUlLJRWRiw6EVcCZ/59IJjSQau1Xvj/O7KfEw4TWsvIWAdjwc88GTl nUttOPV0065mEh9WQ80pjADloLlb3iGegfP1dOwaRtyET+k3MIUpkYIGTGQdiJjU6M PoQ5b8m+BoCTQ== Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 20 Aug 2025 14:56:52 +0200 Message-Id: Subject: Re: [PATCH v3] rust: alloc: implement Box::pin_slice() Cc: , , "Uladzislau Rezki" , "Alice Ryhl" , "Vlastimil Babka" , "Lorenzo Stoakes" , "Liam R . Howlett" , "Miguel Ojeda" , "Alex Gaynor" , "Boqun Feng" , "Gary Guo" , "Bjorn Roy Baron" , "Benno Lossin" , "Andreas Hindborg" , "Trevor Gross" To: "Vitaly Wool" From: "Danilo Krummrich" References: <20250811101456.2901694-1-vitaly.wool@konsulko.se> <3e922cc6-6d27-49ad-9719-5662c6102b6b@konsulko.se> In-Reply-To: <3e922cc6-6d27-49ad-9719-5662c6102b6b@konsulko.se> On Wed Aug 20, 2025 at 10:07 AM CEST, Vitaly Wool wrote: > On 8/11/25 12:14, Vitaly Wool wrote: >> From: Alice Ryhl >>=20 >> Add a new constructor to Box to facilitate Box creation from a pinned >> slice of elements. This allows to efficiently allocate memory for e.g. >> slices of structrures containing spinlocks or mutexes. Such slices may >> be used in kmemcache like or zpool API implementations. >>=20 >> Signed-off-by: Alice Ryhl >> Signed-off-by: Vitaly Wool > > From what I could see, there were no objections to this one. Danilo,=20 > would you be up for picking it or is there something missing about it sti= ll? This looks good now. There's a few minor nits, e.g. it'd be nice to have an empty line between struct definitions in the example and sentences ending with a period. But I= can fix those up on apply.