Re: [PATCH] Rust associative function

["Benno Lossin" <lossin@kernel.org>]

Hi,

Thanks for the patch!

On Wed Aug 20, 2025 at 11:02 PM CEST, Gent Binaku wrote:
> Currently `AlwaysRefCounted::inc_ref` is implemented as a method
> taking `&self`. However, this function should not be called lightly.
> To prevent accidental usage, convert it into an associated function
> instead of a method.
>
> This aligns with the intended API safety model and makes it clearer
> that `inc_ref` is not part of the usual object manipulation methods.
>
> Suggested-by: Benno Lossin <benno.lossin@proton.me>

Please use my <lossin@kernel.org> email instead.

> Link: https://github.com/Rust-for-Linux/linux/issues/1177
> Signed-off-by: Gent Binaku <binakugent@gmail.com>
> ---
>  rust/kernel/auxiliary.rs        | 4 ++--
>  rust/kernel/block/mq/request.rs | 4 ++--
>  rust/kernel/cred.rs             | 4 ++--
>  rust/kernel/device.rs           | 4 ++--
>  rust/kernel/device/property.rs  | 4 ++--
>  rust/kernel/drm/device.rs       | 4 ++--
>  rust/kernel/drm/gem/mod.rs      | 4 ++--
>  rust/kernel/fs/file.rs          | 8 ++++----
>  rust/kernel/mm.rs               | 8 ++++----
>  rust/kernel/mm/mmput_async.rs   | 4 ++--
>  rust/kernel/pci.rs              | 4 ++--
>  rust/kernel/pid_namespace.rs    | 4 ++--
>  rust/kernel/platform.rs         | 4 ++--
>  rust/kernel/sync/aref.rs        | 6 +++---
>  rust/kernel/task.rs             | 4 ++--
>  15 files changed, 35 insertions(+), 35 deletions(-)

We already have someone else working on this, see [1]. Not sure if you
two are coordinating.

You also didn't choose a meaningful commit title.

[1]: https://lore.kernel.org/all/CACvsgUCBk5Dt2yBSy9_NA0z38-wP68vvBX7XDYgJGinTURT1kQ@mail.gmail.com

---
Cheers,
Benno