From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "Christian" <christiansantoslima21@gmail.com>,
"Miguel Ojeda" <miguel.ojeda.sandonis@gmail.com>
Cc: "Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
~lkcamp/patches@lists.sr.ht, richard120310@gmail.com
Subject: Re: [PATCH v10] rust: transmute: Add methods for FromBytes trait
Date: Thu, 28 Aug 2025 09:17:14 +0900 [thread overview]
Message-ID: <DCDMNH6OY7NP.3UE5CGYETB8HI@nvidia.com> (raw)
In-Reply-To: <CABm2a9fQOMvg4Yjqz2-ba=1HwdXiu_Ep=Jsqz--69Vpec+iRXw@mail.gmail.com>
On Tue Aug 26, 2025 at 4:51 AM JST, Christian wrote:
> Hi, Miguel.
>
>
>> > Link: https://github.com/Rust-for-Linux/linux/issues/1119
>> > Suggested-by: Alexandre Courbot <acourbot@nvidia.com>
>>
>> Please add a link to the original suggestion if possible. If it is the
>> link above, then the tags should be in the opposite order.
>>
>> Did Benno and Alexandre both suggest it?
>
> Benno suggested the link to github in the issue there. Alexandre
> helped in most of the design. It was a mistake by my part not to
> specify that. Even if it's good, put you too as suggested-by, because
> the idea of using `is_aligned` was yours. Maybe Alexandre can put it
> there?
>
> If I understand correctly, should be:
>
> Suggested-by: Benno Lossin <benno.lossin@proton.me>,
> Link: https://github.com/Rust-for-Linux/linux/issues/1119
>
> Suggested-by: Alexandre Courbot <acourbot@nvidia.com>
> Link: https://lore.kernel.org/rust-for-linux/DC5INTQKY0EX.1T4HD6OU8C4PI@nvidia.com/
>
> Suggested-by: Miguel Ojeda <ojeda@kernel.org>
> Link: https://lore.kernel.org/rust-for-linux/CANiq72mnxRquFmjoJemb=3LSq+ZdUfs9J+HXTwM6AavprsVNUg@mail.gmail.com/
Unless Miguel disagrees, I'll just keep Benno's entry as what Miguel and
I did was more part of the regular review process IMHO.
next prev parent reply other threads:[~2025-08-28 0:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-24 21:31 [PATCH v10] rust: transmute: Add methods for FromBytes trait Christian S. Lima
2025-08-25 10:24 ` Alice Ryhl
2025-08-25 18:51 ` Christian
2025-08-25 10:39 ` Alexandre Courbot
2025-08-25 14:52 ` Miguel Ojeda
2025-08-25 14:51 ` Miguel Ojeda
2025-08-25 19:51 ` Christian
2025-08-28 0:17 ` Alexandre Courbot [this message]
2025-08-28 6:26 ` Alexandre Courbot
2025-08-29 1:50 ` Alexandre Courbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DCDMNH6OY7NP.3UE5CGYETB8HI@nvidia.com \
--to=acourbot@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=christiansantoslima21@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=richard120310@gmail.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=~lkcamp/patches@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.