From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "John Hubbard" <jhubbard@nvidia.com>,
"Danilo Krummrich" <dakr@kernel.org>
Cc: "Joel Fernandes" <joelagnelf@nvidia.com>,
"Timur Tabi" <ttabi@nvidia.com>,
"Alistair Popple" <apopple@nvidia.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
nouveau@lists.freedesktop.org, linux-pci@vger.kernel.org,
rust-for-linux@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
"Elle Rhumsaa" <elle@weathered-steel.dev>
Subject: Re: [PATCH v7 0/6] rust, nova-core: PCI Class, Vendor support
Date: Thu, 28 Aug 2025 22:27:21 +0900 [thread overview]
Message-ID: <DCE3GFGMZ01P.267QJWUCG4JMQ@nvidia.com> (raw)
In-Reply-To: <20250826231224.1241349-1-jhubbard@nvidia.com>
On Wed Aug 27, 2025 at 8:12 AM JST, John Hubbard wrote:
> Changes since v6:
>
> * Applied changes from Danilo's and Alex's and Elle's reviews (thanks!):
> * Rebased onto driver-core-next, which is here:
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
> * Changed pci::Vendor to be a u16, instead of a u32.
> * Inlined all of the tiniest functions.
> * Changed from Class/Vendor new(), to from_raw().
> * Made from_raw() only accessible to super, which in this case is
> the pci module.
> * Restored infallible operations. That causes Alex's request for the
> following reasonable behavior to work once again:
>
> from_raw(0x10de).as_raw() == 0x10de
>
> * Added a new patch, to inline the remaining PCI operations. This
> provides consistent inline choices throughout pci.rs.
I am far from a PCI expert, but regardless of bus considerations the
code appears to make sense to me (particularly since it removes some
uses of the `bindings` module!). Thus, and FWIW,
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
prev parent reply other threads:[~2025-08-28 13:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-26 23:12 [PATCH v7 0/6] rust, nova-core: PCI Class, Vendor support John Hubbard
2025-08-26 23:12 ` [PATCH v7 1/6] rust: pci: provide access to PCI Class and Class-related items John Hubbard
2025-08-26 23:12 ` [PATCH v7 2/6] rust: pci: provide access to PCI Vendor values John Hubbard
2025-08-28 13:25 ` Alexandre Courbot
2025-08-28 15:07 ` Danilo Krummrich
2025-08-29 21:48 ` John Hubbard
2025-08-26 23:12 ` [PATCH v7 3/6] rust: pci: add DeviceId::from_class_and_vendor() method John Hubbard
2025-08-26 23:12 ` [PATCH v7 4/6] gpu: nova-core: avoid probing non-display/compute PCI functions John Hubbard
2025-08-26 23:12 ` [PATCH v7 5/6] rust: pci: use pci::Vendor instead of bindings::PCI_VENDOR_ID_* John Hubbard
2025-08-28 13:25 ` Alexandre Courbot
2025-08-28 13:59 ` Danilo Krummrich
2025-08-29 21:38 ` John Hubbard
2025-08-29 21:46 ` Danilo Krummrich
2025-08-29 21:49 ` John Hubbard
2025-08-26 23:12 ` [PATCH v7 6/6] rust: pci: inline several tiny functions John Hubbard
2025-08-28 13:27 ` Alexandre Courbot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DCE3GFGMZ01P.267QJWUCG4JMQ@nvidia.com \
--to=acourbot@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=elle@weathered-steel.dev \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=ttabi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.