Re: [PATCH v9 1/1] drm/i915/display: Add no_psr_reason to PSR debugfs

[Sebastian Brzezinka <sebastian.brzezinka@intel.com>]

Hi Miachał

On Mon Sep 1, 2025 at 5:00 PM UTC, Michał Grzelak wrote:
> There is no reason in debugfs why PSR has been disabled. Currently,
> without this information, IGT tests cannot decide whether PSR has
> been disabled on purpose or was it abnormal behavior. Because of it,
> the status of the test cannot be decided correctly.
>
> Add no_psr_reason field into struct intel_psr. Add no_psr_reason
> into struct intel_crtc_state to prevent staying out of sync when
> _psr_compute_config is not using computed state. Write the reason,
> e.g. PSR setup timing not met, into proper PSR debugfs file. Update
> the reason from old_crtc_state in intel_psr_pre_plane_update. Extend
> format of debugfs file to have reason when it is non-NULL. Ensure
> no_psr_reason is up-to-date or NULL by resetting it at the beginning of
> intel_psr_compute_config. Clean it when PSR is activated.
>
> Refactor intel_psr_post_plane_update to use no_psr_reason along
> keep_disabled.
LGTM
Reviewed-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
-- 
Best regards,
Sebastian