From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 092D8CA1015 for ; Thu, 4 Sep 2025 06:00:58 +0000 (UTC) Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) by mx.groups.io with SMTP id smtpd.web11.32630.1756965656599882341 for ; Wed, 03 Sep 2025 23:00:56 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@bootlin.com header.s=dkim header.b=P9tp5BSJ; spf=pass (domain: bootlin.com, ip: 185.246.85.4, mailfrom: mathieu.dubois-briand@bootlin.com) Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 51DA94E40C66 for ; Thu, 4 Sep 2025 06:00:55 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 0FDA2606C4; Thu, 4 Sep 2025 06:00:55 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 729AA1C22A097; Thu, 4 Sep 2025 08:00:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1756965652; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=0iJwHfdRutu1JyEaCvqG2+nOXRYybY1niLfYy6W2fpo=; b=P9tp5BSJzbqVmzDlyzwYi8IjjXVyUyhTQI5sJQwJcugbNx+g2tURmA6dE4jkCgkkyaHqmJ ONo+Z3cIj3NMR7WvYp04RjazlmlI3nyxvljoRCJYLJ8SbHR2bjmvy3r1av7GrAxYjrvpm6 f/t9ZtHH3PRsO1xu675WhljhS+ZqqCRFEO/TKwgbkT5w7lzn3TGXZIGiP2k7c/Be982HsN AIldHqlhKu7cz6Pp9T65+MTTGt26l50u4yvMaj/Cp4WMJFVSf5/fvMd1TnfyI4ypkZK5tp JLIXOAj+5l0h3LSUjj2Dgp1FYCSTwWSbUl/X0VcLqoSmcrv9E2lPoPOihu66DA== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 04 Sep 2025 08:00:48 +0200 Message-Id: From: "Mathieu Dubois-Briand" To: , Subject: Re: [bitbake-devel] [RFC PATCH 0/6] fetch2: add support for implicit urls Cc: "Stefan Herbrechtsmeier" X-Mailer: aerc 0.19.0-0-gadd9e15e475d References: <20250902065507.35737-1-stefan.herbrechtsmeier-oss@weidmueller.com> In-Reply-To: <20250902065507.35737-1-stefan.herbrechtsmeier-oss@weidmueller.com> X-Last-TLS-Session-Version: TLSv1.3 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 04 Sep 2025 06:00:58 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/bitbake-devel/message/17953 On Tue Sep 2, 2025 at 8:55 AM CEST, Stefan Herbrechtsmeier via lists.openem= bedded.org wrote: > From: Stefan Herbrechtsmeier > > The patch series add support for implicit URLs inside the fetcher. The > implicit URLs could be defined inside a source like a version control > system (git submodule) or a lock file (package-lock.json, cargo.lock or > go.sum). The integration of implicit URLs beside explicit URLs > simplifies the fetcher classes and avoid bugs because of iterations > between the Fetch and FetchMethod classes. > > The series remove most methods inside the gitsm fetcher and only leaves > the parsing of the git submodules and the unpack functionality. It > allows the gitsm fetcher to use the premirror only feature. The current > implementation leads to problems because the download of the git > submodules is triggered via the download method which is called deeply > inside the fetcher code. > > > Stefan Herbrechtsmeier (6): > fetch2: rename u to url in Fetch class > fetch2: call functions within loops of Fetch class > fetch2: add helper to get urldata in Fetch class > fetch2: add support for implicit urls > fetch2: gitsm: use implicit urls feature > tests: fetch: add test case for gitsm implicit local paths > > lib/bb/fetch2/__init__.py | 128 +++++++++++++++++++++++++++----------- > lib/bb/fetch2/gitsm.py | 46 ++------------ > lib/bb/tests/fetch.py | 12 ++++ > 3 files changed, 109 insertions(+), 77 deletions(-) Hi Stefan, I know it is just an RFC so far, but I did launch a build on the autobuilder. It was mostly correct but fails a selftest: ERROR: git-submodule-test-1.0-r0 do_ar_mirror: Error executing a python fun= ction in exec_func_python() autogenerated: ... File: '/srv/pokybuild/yocto-worker/oe-selftest-debian/build/bitbake/lib/bb/= fetch2/__init__.py', lineno: 2102, function: expand_urldata ... Exception: UnboundLocalError: cannot access local variable 'urldata' where = it is not associated with a value ... 2025-09-03 06:21:46,098 - oe-selftest - INFO - archiver.Archiver.test_archi= ver_mode_mirror_gitsm (subunit.RemotedTestCase) 2025-09-03 06:21:46,099 - oe-selftest - INFO - ... FAIL And a similar error with archiver.Archiver.test_archiver_mode_mirror_gitsm_shallow. Thanks, Mathieu --=20 Mathieu Dubois-Briand, Bootlin Embedded Linux and Kernel engineering https://bootlin.com