From: "Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>
To: <stefan.herbrechtsmeier-oss@weidmueller.com>,
<bitbake-devel@lists.openembedded.org>
Cc: "Stefan Herbrechtsmeier" <stefan.herbrechtsmeier@weidmueller.com>
Subject: Re: [bitbake-devel] [RFC PATCH v2 0/7] fetch2: add support for implicit urls
Date: Sun, 07 Sep 2025 20:22:01 +0200 [thread overview]
Message-ID: <DCMRZHLSPIC9.3R5OW2CDQ4LNH@bootlin.com> (raw)
In-Reply-To: <20250905064419.2589111-1-stefan.herbrechtsmeier-oss@weidmueller.com>
On Fri Sep 5, 2025 at 8:44 AM CEST, Stefan Herbrechtsmeier via lists.openembedded.org wrote:
> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>
>
> The patch series add support for implicit URLs inside the fetcher. The
> implicit URLs could be defined inside a source like a version control
> system (git submodule) or a lock file (package-lock.json, cargo.lock or
> go.sum). The integration of implicit URLs beside explicit URLs
> simplifies the fetcher classes and avoid bugs because of iterations
> between the Fetch and FetchMethod classes.
>
> The series remove most methods inside the gitsm fetcher and only leaves
> the parsing of the git submodules and the unpack functionality. It
> allows the gitsm fetcher to use the premirror only feature. The current
> implementation leads to problems because the download of the git
> submodules is triggered via the download method which is called deeply
> inside the fetcher code.
>
> Changes in v2:
> - Move test case for gitsm local paths into FetcherLocalTest class
> - Remove implicit urls from localpaths
> - Add commit to test the expanded_urldata function
> - Fix UnboundLocalError of urldata in expand_urldata function
> - Remove implicit URLs from localpaths for backward compatibility
>
> Stefan Herbrechtsmeier (7):
> tests: fetch: add test case for gitsm implicit local paths
> tests: fetch: add test cases for expanded_urldata
> fetch2: rename u to url in Fetch class
> fetch2: call functions within loops of Fetch class
> fetch2: add helper to get urldata in Fetch class
> fetch2: add support for implicit urls
> fetch2: gitsm: use implicit urls feature
>
> lib/bb/fetch2/__init__.py | 127 +++++++++++++++++++++++++++-----------
> lib/bb/fetch2/gitsm.py | 46 ++------------
> lib/bb/tests/fetch.py | 59 ++++++++++++++++++
> 3 files changed, 154 insertions(+), 78 deletions(-)
Thanks,
I took a bit of time to test this new version, no issue on the
autobuilder.
Mathieu
--
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2025-09-07 18:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 6:44 [RFC PATCH v2 0/7] fetch2: add support for implicit urls Stefan Herbrechtsmeier
2025-09-05 6:44 ` [RFC PATCH v2 1/7] tests: fetch: add test case for gitsm implicit local paths Stefan Herbrechtsmeier
2025-09-05 6:44 ` [RFC PATCH v2 2/7] tests: fetch: add test cases for expanded_urldata Stefan Herbrechtsmeier
2025-09-05 6:44 ` [RFC PATCH v2 3/7] fetch2: rename u to url in Fetch class Stefan Herbrechtsmeier
2025-09-05 6:44 ` [RFC PATCH v2 4/7] fetch2: call functions within loops of " Stefan Herbrechtsmeier
2025-09-05 6:44 ` [RFC PATCH v2 5/7] fetch2: add helper to get urldata in " Stefan Herbrechtsmeier
2025-09-05 6:44 ` [RFC PATCH v2 6/7] fetch2: add support for implicit urls Stefan Herbrechtsmeier
2025-09-05 6:44 ` [RFC PATCH v2 7/7] fetch2: gitsm: use implicit urls feature Stefan Herbrechtsmeier
2025-09-07 18:22 ` Mathieu Dubois-Briand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DCMRZHLSPIC9.3R5OW2CDQ4LNH@bootlin.com \
--to=mathieu.dubois-briand@bootlin.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=stefan.herbrechtsmeier-oss@weidmueller.com \
--cc=stefan.herbrechtsmeier@weidmueller.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.