From: "Yeounsu Moon" <yyyynoom@gmail.com>
To: "Simon Horman" <horms@kernel.org>
Cc: "Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] net: natsemi: fix `rx_dropped` double accounting on `netif_rx()` failure
Date: Fri, 12 Sep 2025 23:01:48 +0900 [thread overview]
Message-ID: <DCQVKZ3LKK11.50FS0CMR7ARL@gmail.com> (raw)
In-Reply-To: <20250912132123.GB30363@horms.kernel.org>
On Fri Sep 12, 2025 at 10:21 PM KST, Simon Horman wrote:
>
> Thanks for your patch,
>
Thank you very much for your review, Simon :)
> Thinking out loud: Adding use of ndev->stats to drivers that don't already
> do so is discouraged. But here, an existing use is being fixed. And I agree
> it is a fix. So this looks good to me.
>
> Reviewed-by: Simon Horman <horms@kernel.org>
I also noticed that many drivers are still using `ndev->stats`.
If I work on related changes in the future, I will make sure to use
`struct rtnl_link_stats64` instaed and post patches accordingly.
next prev parent reply other threads:[~2025-09-12 14:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 5:33 [PATCH net] net: natsemi: fix `rx_dropped` double accounting on `netif_rx()` failure Yeounsu Moon
2025-09-12 13:21 ` Simon Horman
2025-09-12 14:01 ` Yeounsu Moon [this message]
2025-09-12 14:19 ` Eric Dumazet
2025-09-12 15:50 ` Yeounsu Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DCQVKZ3LKK11.50FS0CMR7ARL@gmail.com \
--to=yyyynoom@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.