From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0537F83A14 for ; Wed, 24 Sep 2025 16:37:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758731823; cv=none; b=OBVhizbfcy6mpLzZnh7u/ogJ7ouZusEgj6hYSIn4muw/kaaTNY00Uj96ZOYXt8JtE7oX16gPxF+s7YegPFUWPzAdcVBQDkW0ENt9huSaVMj3VXBRvF5YK7vOhpnvL4MGm1nJpTYz0D93+ecdZpeVXdGoXg7P7Pz04cpbSsUS/ko= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758731823; c=relaxed/simple; bh=slMHZf7pDj+LFIrXTqw09zXP6T1Q1gmwv3Y28fwaRO4=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=r5kSqIOZq0nyfwRtQw0jqcY+afwXVHNVDh5CNuBViHHa9CzwfDcHSsqPhj6UV1N7g5ajXaWcfN5CXyrKwsOJ2/jSVJ3x3mctr2g7/oV4L7y//oXNG381mGfWbvo5Fyl12tsiVCtLDKFi12iiw42GbXocWLoISYQxACEQJA91O4o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DvSgCOis; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DvSgCOis" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-780f6632e64so19884b3a.2 for ; Wed, 24 Sep 2025 09:37:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758731821; x=1759336621; darn=vger.kernel.org; h=in-reply-to:references:from:to:cc:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=z3wqzINicnkLL2c14gwZ1hx+hWX66mtEw47ebSibOks=; b=DvSgCOis5AC8MvFwMlKcNFkj6pGO3wBPWML9+EKEwhyq1oFV0I2uXi5wvZzXnIGxnV 95iHDdRhbjMjvRX/2w55u8I1eQXdo9cwvJk8CHqPBslUBNFkOXLrYKeAurd9DCk+bcUE W3bKMmIdULAZf0Sxcdx0iITFQwjmC6hlNj0NzswXtZqasURqj/tgdU1/Xqh+3ibdDEq3 OrtVq5OKyAkTaPkfNg8vikRjP2xtrPlN/p0V+CXBWpDw+29Y/tR96n51mF7dxIbro4VU 64P1QaF4jDkTH4t2qMkMWV1mLJdzume7MKUMhi1JMTphrZ2byvNqapAVHRc87PQgv9zJ d4Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758731821; x=1759336621; h=in-reply-to:references:from:to:cc:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=z3wqzINicnkLL2c14gwZ1hx+hWX66mtEw47ebSibOks=; b=hKM+/B+jJw7m0yKoFgQKWUXzwM+Sh5Q3wEq3X7gV/9HQBaxSqVOPAO/nlMk4RZLdhv Rudpu28aDA10uTXEpHfRxepP+5HKBKe3TggwYHRDOFsk7P0id2bFgAI4HYYu5avvOGqu wkxeaU00dMV+seBLw9cBdxIzzycRlDe8ITBer81x/9P+EH6AuL7Kn74QiO+ohW8QagiT bRLQEm68NknLELVqHvvUBOmDvGRBsWAIAZFWhGb0eakLurDHWlkF7uONNNebHAYSY/G5 nzrgaGqfs6uCOUUV0bYIMljKmgXXm1AEzb7CG52DmVg76ZdnGJ/akb8rR/07WzwFeiMZ FZwQ== X-Forwarded-Encrypted: i=1; AJvYcCWDhvJSsrUDAZKDu2s1qoph7+jz9yMQLJG9gdu1zK4sosR08Q3v+R/cBKs+g2ujngNt8vxq7wY=@vger.kernel.org X-Gm-Message-State: AOJu0YyQHDnBalsdPOlBmHEihu3F3pQRyS1PB85JOFHcdw2dAynIthTa k7qp6eF0LrR4VllQLKFQsGAAAEhgvtYGQcQ7083/eaExGya7hedmBQQx X-Gm-Gg: ASbGncsTEQMU4Ff10bID4dxTuKs6KJ/O+PlKqLWRKZbmTzThbpAXsFfRs+jPiy6f/9f dAHycgTQc+o/oh2EXvsb4pZLryr8Og6dXhta8U1pWKq2qXifZX/+eSVHHTnarmZI3p2wQ/0q1+G ODvFgDSpMYsidN0XzpUK9RKBPPhXBdZOz+DEPYba+nBAc9kSxowiUkU8l4bRjSne0Vst/J2U87J Du+dTkxem6/Vfu9/hY+6rzNZwpNdYpEeSWOSDm2PgLEyCIHDq3sux1tCcCcU/hdu3dbBk1bPLr6 7QpCKwMdGOUaznqIQrJNuea6061lI86u1EgAetl4KMO7AtxYeQbay6o6HSQ1d9BazjgxN3dICDb zQ2hNrnqdWibwcks6gXSUc80IgbrkYPGErWjoFe7h2Zj2HbAyEosc X-Google-Smtp-Source: AGHT+IHIiPcXqnb4ZuXzHkhTE/WRNCDaCxsTg2AL8U2suEQAkNt7mCt5UlbYVTc4ITkK9ujzuppd6w== X-Received: by 2002:a05:6300:2109:b0:2ba:eb8c:92e7 with SMTP id adf61e73a8af0-2e7d2c5cf1cmr258004637.49.1758731821173; Wed, 24 Sep 2025 09:37:01 -0700 (PDT) Received: from localhost ([121.159.229.173]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b551b31ebb2sm14540645a12.6.2025.09.24.09.36.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Sep 2025 09:37:00 -0700 (PDT) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 25 Sep 2025 01:36:57 +0900 Message-Id: Subject: Re: [PATCH net v3 2/2] net: dlink: handle copy_thresh allocation failure Cc: "Andrew Lunn" , "David S. Miller" , "Eric Dumazet" , "Paolo Abeni" , , To: "Jakub Kicinski" From: "Yeounsu Moon" X-Mailer: aerc 0.20.1 References: <20250916183305.2808-1-yyyynoom@gmail.com> <20250916183305.2808-3-yyyynoom@gmail.com> <20250917160924.6c2a5f47@kernel.org> In-Reply-To: <20250917160924.6c2a5f47@kernel.org> On Thu Sep 18, 2025 at 8:09 AM KST, Jakub Kicinski wrote: Thank you for reviewing! and sorry for the delayed reply. There have been quite a lot of things on my end recently. > On Wed, 17 Sep 2025 03:33:05 +0900 Yeounsu Moon wrote: >> @@ -965,14 +965,11 @@ receive_packet (struct net_device *dev) >> struct sk_buff *skb; >> =20 >> /* Small skbuffs for short packets */ >> - if (pkt_len > copy_thresh) { >> - dma_unmap_single(&np->pdev->dev, >> - desc_to_dma(desc), >> - np->rx_buf_sz, >> - DMA_FROM_DEVICE); >> - skb_put(skb =3D np->rx_skbuff[entry], pkt_len); >> - np->rx_skbuff[entry] =3D NULL; >> - } else if ((skb =3D netdev_alloc_skb_ip_align(dev, pkt_len))) { >> + if (pkt_len <=3D copy_thresh) { >> + skb =3D netdev_alloc_skb_ip_align(dev, pkt_len); >> + if (!skb) >> + goto fallback_to_normal_path; > > The goto looks pretty awkward. > > skb =3D NULL; > if (pkt_len <=3D copy_thresh) > skb =3D netdev_alloc_skb_ip_align(dev, pkt_len); > if (!skb) { > // existing non-copy path > } else { > // existing copybreak path > } I totally agree with your point. However, the two cases handle `skb` and `rx_skbuff` differently depending on the `copy_thresh` condition, regardless of whether `skb` is NULL or not. This patch is only intended to gracefully handle the failure case when `skb= ` allocation fails. Yeounsu Moon