From: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
To: Krzysztof Niemiec <krzysztof.niemiec@intel.com>,
<igt-dev@lists.freedesktop.org>
Cc: Chris Wilson <chris.p.wilson@linux.intel.com>,
Andi Shyti <andi.shyti@linux.intel.com>,
Krzysztof Karas <krzysztof.karas@intel.com>,
Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>,
Zbigniew Kempczynski <zbigniew.kempczynski@intel.com>
Subject: Re: [PATCH v2 i-g-t] tests/intel/gem_exec_schedule: Improve synchronization in pi-ringfull
Date: Mon, 29 Sep 2025 13:36:54 +0000 [thread overview]
Message-ID: <DD5BP6AIX3HG.3ASSNSJBUL7NL@intel.com> (raw)
In-Reply-To: <20250926180302.61612-2-krzysztof.niemiec@intel.com>
Hi Krzysztof
On Fri Sep 26, 2025 at 6:03 PM UTC, Krzysztof Niemiec wrote:
> Move the interrupt timer from the parent thread to the child thread as
> an explicit signal raise, and make sure the order of execution between
> them is always the same. This reduces nondeterminism in the test, fixing
> bugs like [1], where the child is starved out of CPU time up until the
> parent gets signalled and monopolizes the CPU before the child could
> submit its own execbuf, failing the test.
>
> [1] https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/14898
>
> v2: make the sync variable actually work (Zbigniew)
>
> Signed-off-by: Krzysztof Niemiec <krzysztof.niemiec@intel.com>
LGTM
Reviewed-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
--
Best regards,
Sebastian
prev parent reply other threads:[~2025-09-29 13:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-26 18:03 [PATCH v2 i-g-t] tests/intel/gem_exec_schedule: Improve synchronization in pi-ringfull Krzysztof Niemiec
2025-09-26 19:20 ` ✓ Xe.CI.BAT: success for tests/intel/gem_exec_schedule: Improve synchronization in pi-ringfull (rev2) Patchwork
2025-09-26 19:36 ` ✓ i915.CI.BAT: " Patchwork
2025-09-27 1:20 ` ✗ i915.CI.Full: failure " Patchwork
2025-09-27 2:12 ` ✗ Xe.CI.Full: " Patchwork
2025-09-29 5:47 ` [PATCH v2 i-g-t] tests/intel/gem_exec_schedule: Improve synchronization in pi-ringfull Zbigniew Kempczyński
2025-09-29 6:02 ` Krzysztof Karas
2025-09-29 8:44 ` Janusz Krzysztofik
2025-09-29 13:29 ` Krzysztof Niemiec
2025-09-30 9:35 ` Kamil Konieczny
2025-09-29 13:36 ` Sebastian Brzezinka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DD5BP6AIX3HG.3ASSNSJBUL7NL@intel.com \
--to=sebastian.brzezinka@intel.com \
--cc=andi.shyti@linux.intel.com \
--cc=chris.p.wilson@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=janusz.krzysztofik@linux.intel.com \
--cc=krzysztof.karas@intel.com \
--cc=krzysztof.niemiec@intel.com \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.