From: Alejandro Vallejo <alejandro.garciavallejo@amd.com>
To: Michal Orzel <michal.orzel@amd.com>, <xen-devel@lists.xenproject.org>
Cc: Anthony PERARD <anthony.perard@vates.tech>,
Xen-devel <xen-devel-bounces@lists.xenproject.org>
Subject: Re: [PATCH v2] tools: init-dom0less: Replace err() with more informative messages
Date: Tue, 7 Oct 2025 11:11:56 +0200 [thread overview]
Message-ID: <DDBZ2NZECIMD.200RAWMH4ON51@amd.com> (raw)
In-Reply-To: <20251007062656.4254-1-michal.orzel@amd.com>
On Tue Oct 7, 2025 at 8:26 AM CEST, Michal Orzel wrote:
> Current use of err() has the following issues:
> - without setting errno, on error it results in printing e.g.:
> "init-dom0less: writing to xenstore: Success"
> This is very misleading and difficult to deduct that there was a
> failure.
> - does not propagate error codes to the caller.
> - skips "init_domain failed" message by exiting early.
> - early exit prevents setting up any remaining domains.
>
> Replace err() with more informative messages propagating rc when
> possible.
>
> Signed-off-by: Michal Orzel <michal.orzel@amd.com>
Reviewed-by: Alejandro Vallejo <alejandro.garciavallejo@amd.com>
Cheers,
Alejandro
next prev parent reply other threads:[~2025-10-07 9:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-07 6:26 [PATCH v2] tools: init-dom0less: Replace err() with more informative messages Michal Orzel
2025-10-07 9:11 ` Alejandro Vallejo [this message]
2025-10-07 12:20 ` Jason Andryuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DDBZ2NZECIMD.200RAWMH4ON51@amd.com \
--to=alejandro.garciavallejo@amd.com \
--cc=anthony.perard@vates.tech \
--cc=michal.orzel@amd.com \
--cc=xen-devel-bounces@lists.xenproject.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.