All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Danilo Krummrich" <dakr@kernel.org>
To: "Matthew Brost" <matthew.brost@intel.com>
Cc: "Christian König" <christian.koenig@amd.com>,
	dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
	alexdeucher@gmail.com, pstanner@redhat.com,
	"Philipp Stanner" <phasta@kernel.org>
Subject: Re: [RFC PATCH 1/4] drm/sched: Add pending job list iterator
Date: Tue, 07 Oct 2025 11:51:47 +0200	[thread overview]
Message-ID: <DDBZX652KAXI.22E6JCVD9FZ1F@kernel.org> (raw)
In-Reply-To: <aOTg47xjxt6cFnIF@lstrano-desk.jf.intel.com>

On Tue Oct 7, 2025 at 11:44 AM CEST, Matthew Brost wrote:
> Honestly I'd just lean towards dropping the debug version then. It is
> basically useless information in Xe as the number of pending jobs can
> dervived from the ring's seqnos which is also printed.

Yes, either do that or provide a dedicated debugfs layer in the scheduler
itself.

For printing driver specific job information we can easily add a callback.

  reply	other threads:[~2025-10-07  9:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-02  5:16 [RFC PATCH 0/4] Fix DRM scheduler layering violations in Xe Matthew Brost
2025-10-02  5:16 ` [RFC PATCH 1/4] drm/sched: Add pending job list iterator Matthew Brost
2025-10-07  7:28   ` Christian König
2025-10-07  8:09     ` Matthew Brost
2025-10-07  8:28       ` Matthew Brost
2025-10-07  8:44         ` Christian König
2025-10-07  9:44           ` Matthew Brost
2025-10-07  9:51             ` Danilo Krummrich [this message]
2025-10-02  5:16 ` [RFC PATCH 2/4] drm/sched: Add several job helpers to avoid drivers touching scheduler state Matthew Brost
2025-10-02  5:16 ` [RFC PATCH 3/4] drm/xe: Add dedicated message lock Matthew Brost
2025-10-02  5:16 ` [RFC PATCH 4/4] drm/xe: Stop abusing DRM scheduler internals Matthew Brost
2025-10-02  6:01 ` ✗ CI.checkpatch: warning for Fix DRM scheduler layering violations in Xe Patchwork
2025-10-02  6:02 ` ✓ CI.KUnit: success " Patchwork
2025-10-02  6:38 ` ✓ Xe.CI.BAT: " Patchwork
2025-10-02  7:58 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DDBZX652KAXI.22E6JCVD9FZ1F@kernel.org \
    --to=dakr@kernel.org \
    --cc=alexdeucher@gmail.com \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    --cc=phasta@kernel.org \
    --cc=pstanner@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.