All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rahul Sandhu" <nvraxn@gmail.com>
To: <stephen.smalley.work@gmail.com>
Cc: <jwcart2@gmail.com>, <nvraxn@gmail.com>, <selinux@vger.kernel.org>
Subject: Re: [PATCH v5] seunshare: fix the frail tmpdir cleanup
Date: Tue, 07 Oct 2025 18:02:09 +0100	[thread overview]
Message-ID: <DDC92OTGUZC7.OWZX9FSUWYQN@gmail.com> (raw)
In-Reply-To: <CAEjxPJ4wxMi0kXc7wDi qwboAcz1Y0UvzDoZMZrpUgcNH_cNRg@mail.gmail.com>

> With this patch applied, I see the following output when I use sandbox
> -M and create anything in the tmpdir.
> 
> $ sandbox -M bash
> bash: cannot set terminal process group (-1): Inappropriate ioctl for device
> bash: no job control in this shell
> bash-5.2$ mkdir /tmp/foobar
> bash-5.2$ exit
> Failed to recursively remove directory /tmp/.sandbox-sdsmall-chjRXi

Some idiot just spent a few hours trying to reproduce this and failing,
because they changed the function signature to an int to a bool, and
although they commited that, turns out that this was unstaged:
-                       if (rm_rf(dirfd(dir), entry->d_name) != 0) {
+                       if (!rm_rf(dirfd(dir), entry->d_name)) {

...

I'm really sorry, new patch coming soon.

Regards,
Rahul

       reply	other threads:[~2025-10-07 17:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAEjxPJ4wxMi0kXc7wDi qwboAcz1Y0UvzDoZMZrpUgcNH_cNRg@mail.gmail.com>
2025-10-07 17:02 ` Rahul Sandhu [this message]
2025-10-07 17:06   ` [PATCH v6] seunshare: fix the frail tmpdir cleanup Rahul Sandhu
2025-10-07 17:42     ` Stephen Smalley
2025-10-07 18:01       ` Stephen Smalley
2025-10-07 18:09         ` [PATCH v7] " Rahul Sandhu
2025-10-07 18:20           ` Stephen Smalley
2025-10-08 13:16             ` Stephen Smalley
2025-10-06 18:40 [PATCH v4] " Stephen Smalley
2025-10-07  9:29 ` [PATCH v5] " Rahul Sandhu
2025-10-07 12:46   ` Stephen Smalley
2025-10-07 14:09     ` Stephen Smalley
2025-10-07 16:59       ` Rahul Sandhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DDC92OTGUZC7.OWZX9FSUWYQN@gmail.com \
    --to=nvraxn@gmail.com \
    --cc=jwcart2@gmail.com \
    --cc=selinux@vger.kernel.org \
    --cc=stephen.smalley.work@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.