All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ilias Apalodimas" <ilias.apalodimas@linaro.org>
To: "Tom Rini" <trini@konsulko.com>, <u-boot@lists.denx.de>
Subject: Re: [PATCH] tpm: Make U_BOOT_DRIVER entries unique
Date: Thu, 09 Oct 2025 09:12:41 +0300	[thread overview]
Message-ID: <DDDKIIEGKFEW.13JEXMATMUFW@linaro.org> (raw)
In-Reply-To: <20250925205623.3562621-1-trini@konsulko.com>

Hi Tom,

On Thu Sep 25, 2025 at 11:56 PM EEST, Tom Rini wrote:
> All instances of the U_BOOT_DRIVER must use a unique name or they will
> lead to link time failures due to name space conflicts when both are
> present. In this case the driver was reusing the tpm_tis_i2c name.
>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
>  drivers/tpm/tpm_tis_infineon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tpm/tpm_tis_infineon.c b/drivers/tpm/tpm_tis_infineon.c
> index 30f23f8610a3..c1e7b98295c5 100644
> --- a/drivers/tpm/tpm_tis_infineon.c
> +++ b/drivers/tpm/tpm_tis_infineon.c
> @@ -626,7 +626,7 @@ static const struct udevice_id tpm_tis_i2c_ids[] = {
>  	{ }
>  };
>  
> -U_BOOT_DRIVER(tpm_tis_i2c) = {
> +U_BOOT_DRIVER(tpm_tis_infineon) = {
>  	.name   = "tpm_tis_infineon",
>  	.id     = UCLASS_TPM,
>  	.of_match = tpm_tis_i2c_ids,

I somehow missed this 
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>


      reply	other threads:[~2025-10-09  6:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-25 20:56 [PATCH] tpm: Make U_BOOT_DRIVER entries unique Tom Rini
2025-10-09  6:12 ` Ilias Apalodimas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DDDKIIEGKFEW.13JEXMATMUFW@linaro.org \
    --to=ilias.apalodimas@linaro.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.