From: "Luca Ceresoli" <luca.ceresoli@bootlin.com>
To: "Carlos Llamas" <cmllamas@google.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Matthieu Baerts (NGI0)" <matttbe@kernel.org>,
"Breno Leitao" <leitao@debian.org>,
"Miroslav Benes" <mbenes@suse.cz>,
"Mark Brown" <broonie@kernel.org>,
"Puranjay Mohan" <puranjay@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Catalin Marinas" <catalin.marinas@arm.com>
Cc: <kernel-team@android.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scripts/decode_stacktrace.sh: fix build ID and PC source parsing
Date: Thu, 30 Oct 2025 15:50:52 +0100 [thread overview]
Message-ID: <DDVQOOYR7YOO.3L40JABB6VVUW@bootlin.com> (raw)
In-Reply-To: <20251030010347.2731925-1-cmllamas@google.com>
Hello,
On Thu Oct 30, 2025 at 2:03 AM CET, Carlos Llamas wrote:
> Support for parsing PC source info in stacktraces (e.g. '(P)') was
> added in commit 2bff77c665ed ("scripts/decode_stacktrace.sh: fix
> decoding of lines with an additional info"). However, this logic was
> placed after the build ID processing. This incorrect order fails to
> parse lines containing both elements, e.g.:
>
> drm_gem_mmap_obj+0x114/0x200 [drm 03d0564e0529947d67bb2008c3548be77279fd27] (P)
>
> This patch fixes the problem by extracting the PC source info first and
> then processing the module build ID. With this change, the line above is
> now properly parsed as such:
>
> drm_gem_mmap_obj (./include/linux/mmap_lock.h:212 ./include/linux/mm.h:811 drivers/gpu/drm/drm_gem.c:1177) drm (P)
>
> While here, also add a brief explanation the build ID section.
>
> Fixes: bdf8eafbf7f5 ("arm64: stacktrace: report source of unwind data")
> Fixes: 2bff77c665ed ("scripts/decode_stacktrace.sh: fix decoding of lines with an additional info")
> Signed-off-by: Carlos Llamas <cmllamas@google.com>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2025-10-30 14:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 1:03 [PATCH] scripts/decode_stacktrace.sh: fix build ID and PC source parsing Carlos Llamas
2025-10-30 12:24 ` Matthieu Baerts
2025-10-30 14:50 ` Luca Ceresoli [this message]
2025-10-31 3:57 ` Andrew Morton
2025-11-06 0:59 ` Carlos Llamas
2025-11-07 0:48 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DDVQOOYR7YOO.3L40JABB6VVUW@bootlin.com \
--to=luca.ceresoli@bootlin.com \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=cmllamas@google.com \
--cc=kernel-team@android.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matttbe@kernel.org \
--cc=mbenes@suse.cz \
--cc=puranjay@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.