From: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
To: Sebastian Brzezinka <sebastian.brzezinka@intel.com>,
<intel-gfx@lists.freedesktop.org>, <chris.p.wilson@intel.com>,
<andi.shyti@linux.intel.com>, <krzysztof.karas@intel.com>,
<krzysztof.niemiec@intel.com>
Subject: Re: [RFC PATCH] drm/i915: Use rcu_dereference() in hwsp_offset()
Date: Tue, 4 Nov 2025 11:42:36 +0000 [thread overview]
Message-ID: <DDZVT9PA03KT.LR5IN7DU0JXA@intel.com> (raw)
In-Reply-To: <20251104113318.3823840-1-sebastian.brzezinka@intel.com>
TL;DR:
1. If rcu_dereference_protected is intended to prevent use-after-free, it currently doesn’t.
2. Does anyone know how we end up in this state and what the proper way to prevent it is?
Adding an if check before engine->emit_fini_breadcrumb feels like a hack.
--
Best regards,
Sebastian
next prev parent reply other threads:[~2025-11-04 11:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 11:33 [RFC PATCH] drm/i915: Use rcu_dereference() in hwsp_offset() Sebastian Brzezinka
2025-11-04 11:42 ` Sebastian Brzezinka [this message]
2025-11-05 1:59 ` ✗ i915.CI.BAT: failure for " Patchwork
2025-11-19 10:29 ` ✗ i915.CI.BAT: failure for drm/i915: Use rcu_dereference() in hwsp_offset() (rev2) Patchwork
2025-11-19 15:58 ` [RFC PATCH] drm/i915: Use rcu_dereference() in hwsp_offset() Janusz Krzysztofik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DDZVT9PA03KT.LR5IN7DU0JXA@intel.com \
--to=sebastian.brzezinka@intel.com \
--cc=andi.shyti@linux.intel.com \
--cc=chris.p.wilson@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=krzysztof.karas@intel.com \
--cc=krzysztof.niemiec@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.