From: Anshul Dalal <anshuld@ti.com>
To: Anshul Dalal <anshuld@ti.com>, <u-boot@lists.denx.de>
Cc: Tom Rini <trini@konsulko.com>, Andrew Davis <afd@ti.com>,
Judith Mendez <jm@ti.com>, Udit Kumar <u-kumar1@ti.com>,
Hrushikesh Salunke <h-salunke@ti.com>,
Neha Malcom Francis <n-francis@ti.com>,
Vignesh R <vigneshr@ti.com>,
Christoph Niedermaier <cniedermaier@dh-electronics.com>
Subject: Re: [PATCH] configs: am65x_usbdfu: add SPL_USE_TINY_PRINTF_POINTER_SUPPORT
Date: Wed, 5 Nov 2025 11:35:03 +0530 [thread overview]
Message-ID: <DE0J9DJSVAS3.339E9U0OW3BPI@ti.com> (raw)
In-Reply-To: <20251105-am65_dfu_fix-v1-1-acc29111dccf@ti.com>
On Wed Nov 5, 2025 at 11:32 AM IST, Anshul Dalal wrote:
> Since the commit 1e24e84db41a ("tiny-printf: Handle formatting of %p
> with an extra Kconfig"), SPL_USE_TINY_PRINTF_POINTER_SUPPORT has been
> made mandatory in order to use %p which would earlier have defaulted to
> a 'long' print.
>
> Without this config symbol, k3_sysfw_dfu_download fails to set the
> correct value for the DFU string with:
>
> sprintf(dfu_str, "sysfw.itb ram 0x%p 0x%x", addr,
> CONFIG_K3_SYSFW_IMAGE_SIZE_MAX);
>
> The value we get "sysfw.itb ram 0x? 0x41c29d40" causes a boot failure.
>
> Therefore this patch sets SPL_USE_TINY_PRINTF_POINTER_SUPPORT for the
> usbdfu defconfig and also cleans up the usage of "CONFIG_*=n".
>
> Signed-off-by: Anshul Dalal <anshuld@ti.com>
> ---
> Not sure if a 'Fixes' tag is appropriate here since the commit
> 1e24e84db41a ("tiny-printf: Handle formatting of %p with an extra
> Kconfig") did cause a regression though I think the problem existed with
> the usage of "%p" with TINY_PRINTF set to begin with.
> ---
> configs/am65x_evm_r5_usbdfu_defconfig | 63 ++++++++++++++++++-----------------
> 1 file changed, 32 insertions(+), 31 deletions(-)
>
> diff --git a/configs/am65x_evm_r5_usbdfu_defconfig b/configs/am65x_evm_r5_usbdfu_defconfig
> index f9161f1fe111ff97f7aa79f10b21c3b0ab1dad32..b3def7946b3eb799582f04cc522725cb3f9a6eb1 100644
> --- a/configs/am65x_evm_r5_usbdfu_defconfig
> +++ b/configs/am65x_evm_r5_usbdfu_defconfig
> @@ -6,6 +6,7 @@ CONFIG_SYS_MALLOC_F_LEN=0x57000
> CONFIG_SPL_GPIO=y
> CONFIG_SPL_LIBCOMMON_SUPPORT=y
> CONFIG_SPL_LIBGENERIC_SUPPORT=y
> +CONFIG_SPL_USE_TINY_PRINTF_POINTER_SUPPORT=y
> CONFIG_SOC_K3_AM654=y
> CONFIG_K3_EARLY_CONS=y
> CONFIG_TARGET_AM654_R5_EVM=y
> @@ -41,34 +42,34 @@ CONFIG_USB_GADGET_VENDOR_NUM=0x0451
> CONFIG_USB_GADGET_PRODUCT_NUM=0x6162
> CONFIG_USB_GADGET_DOWNLOAD=y
> CONFIG_SPL_DFU=y
> -CONFIG_MMC=n
> -CONFIG_SPL_DM_SPI=n
> -CONFIG_SPL_MMC=n
> -CONFIG_SPL_FS_FAT=n
> -CONFIG_SPL_SPI_FLASH_SUPPORT=n
> -CONFIG_SPL_SPI=n
> -CONFIG_SPL_SYS_MMCSD_RAW_MODE=n
> -CONFIG_SPL_DM_SPI_FLASH=n
> -CONFIG_SPL_SPI_FLASH_SFDP_SUPPORT=n
> -CONFIG_SPL_SPI_LOAD=n
> -CONFIG_CMD_MMC=n
> -CONFIG_ENV_OVERWRITE=n
> -CONFIG_ENV_IS_IN_FAT=n
> -CONFIG_DMA_CHANNELS=n
> -CONFIG_TI_K3_NAVSS_UDMA=n
> -CONFIG_SUPPORT_EMMC_BOOT=n
> -CONFIG_MMC_HS200_SUPPORT=n
> -CONFIG_SPL_MMC_HS200_SUPPORT=n
> -CONFIG_MMC_SDHCI=n
> -CONFIG_SPL_MMC_SDHCI_ADMA=n
> -CONFIG_MMC_SDHCI_AM654=n
> -CONFIG_MTD=n
> -CONFIG_DM_SPI_FLASH=n
> -CONFIG_SPI_FLASH_SFDP_SUPPORT=n
> -CONFIG_SPI_FLASH_STMICRO=n
> -CONFIG_SOC_DEVICE=n
> -CONFIG_SOC_DEVICE_TI_K3=n
> -CONFIG_SOC_TI=n
> -CONFIG_SPI=n
> -CONFIG_DM_SPI=n
> -CONFIG_CADENCE_QSPI=n
> +# CONFIG_MMC is not set
> +# CONFIG_SPL_DM_SPI is not set
> +# CONFIG_SPL_MMC is not set
> +# CONFIG_SPL_FS_FAT is not set
> +# CONFIG_SPL_SPI_FLASH_SUPPORT is not set
> +# CONFIG_SPL_SPI is not set
> +# CONFIG_SPL_SYS_MMCSD_RAW_MODE is not set
> +# CONFIG_SPL_DM_SPI_FLASH is not set
> +# CONFIG_SPL_SPI_FLASH_SFDP_SUPPORT is not set
> +# CONFIG_SPL_SPI_LOAD is not set
> +# CONFIG_CMD_MMC is not set
> +# CONFIG_ENV_OVERWRITE is not set
> +# CONFIG_ENV_IS_IN_FAT is not set
> +# CONFIG_DMA_CHANNELS is not set
> +# CONFIG_TI_K3_NAVSS_UDMA is not set
> +# CONFIG_SUPPORT_EMMC_BOOT is not set
> +# CONFIG_MMC_HS200_SUPPORT is not set
> +# CONFIG_SPL_MMC_HS200_SUPPORT is not set
> +# CONFIG_MMC_SDHCI is not set
> +# CONFIG_SPL_MMC_SDHCI_ADMA is not set
> +# CONFIG_MMC_SDHCI_AM654 is not set
> +# CONFIG_MTD is not set
> +# CONFIG_DM_SPI_FLASH is not set
> +# CONFIG_SPI_FLASH_SFDP_SUPPORT is not set
> +# CONFIG_SPI_FLASH_STMICRO is not set
> +# CONFIG_SOC_DEVICE is not set
> +# CONFIG_SOC_DEVICE_TI_K3 is not set
> +# CONFIG_SOC_TI is not set
> +# CONFIG_SPI is not set
> +# CONFIG_DM_SPI is not set
> +# CONFIG_CADENCE_QSPI is not set
>
> ---
> base-commit: 1c250e444ad3b15315ee8b0fcb3fc3acc26449e2
> change-id: 20251105-am65_dfu_fix-1144eec06b19
>
> Best regards,
CC: +Christoph Niedermaier
next prev parent reply other threads:[~2025-11-05 6:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 6:02 [PATCH] configs: am65x_usbdfu: add SPL_USE_TINY_PRINTF_POINTER_SUPPORT Anshul Dalal
2025-11-05 6:05 ` Anshul Dalal [this message]
2025-11-05 13:54 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DE0J9DJSVAS3.339E9U0OW3BPI@ti.com \
--to=anshuld@ti.com \
--cc=afd@ti.com \
--cc=cniedermaier@dh-electronics.com \
--cc=h-salunke@ti.com \
--cc=jm@ti.com \
--cc=n-francis@ti.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.