Re: [PATCH v8 5/6] gpu: nova-core: add boot42 support for next-gen GPUs

["Alexandre Courbot" <acourbot@nvidia.com>]

On Fri Nov 14, 2025 at 11:41 AM JST, John Hubbard wrote:
<snip>
> diff --git a/drivers/gpu/nova-core/regs.rs b/drivers/gpu/nova-core/regs.rs
> index 8c9af3c59708..81097e83c276 100644
> --- a/drivers/gpu/nova-core/regs.rs
> +++ b/drivers/gpu/nova-core/regs.rs
> @@ -41,14 +41,24 @@
>  });
>  
>  impl NV_PMC_BOOT_0 {
> -    /// Combines `architecture_0` and `architecture_1` to obtain the architecture of the chip.
> -    pub(crate) fn architecture(self) -> Result<Architecture> {
> -        Architecture::try_from(
> -            self.architecture_0() | (self.architecture_1() << Self::ARCHITECTURE_0_RANGE.len()),
> -        )
> +    pub(crate) fn is_older_than_fermi(self) -> bool {
> +        // From https://github.com/NVIDIA/open-gpu-doc/tree/master/manuals :
> +        const NV_PMC_BOOT_0_ARCHITECTURE_GF100: u8 = 0xc;
> +
> +        // Older chips left arch1 zeroed out. That, combined with an arch0 value that is less than
> +        // GF100, means "older than Fermi".
> +        self.architecture_1() == 0 && self.architecture_0() < NV_PMC_BOOT_0_ARCHITECTURE_GF100
>      }
> +}
> +
> +register!(NV_PMC_BOOT_42 @ 0x00000a00, "Extended architecture information" {
> +    15:12   minor_revision as u8, "Minor revision of the chip";
> +    19:16   major_revision as u8, "Major revision of the chip";
> +    23:20   implementation as u8, "Implementation version of the architecture";
> +    29:24   architecture as u8 ?=> Architecture, "Architecture value";
> +});
>  
> -    /// Combines `architecture` and `implementation` to obtain a code unique to the chipset.

This comment for the `chipset` method got deleted. Is there a reason? If not I'll restore it when applying.