All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Thomas Bonnefille" <thomas.bonnefille@bootlin.com>
To: "Francesco Dolcini" <francesco@dolcini.it>,
	"Thomas Bonnefille" <thomas.bonnefille@bootlin.com>
Cc: u-boot@lists.denx.de, "NXP i.MX U-Boot Team" <uboot-imx@nxp.com>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Miquèl Raynal" <miquel.raynal@bootlin.com>,
	"Anatolij Gustschin" <ag.dev.uboot@gmail.com>,
	"Tom Rini" <trini@konsulko.com>,
	"Stefano Babic" <sbabic@nabladev.com>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Simon Glass" <sjg@chromium.org>,
	"Francesco Dolcini" <francesco.dolcini@toradex.com>
Subject: Re: [PATCH 5/5] board: toradex: add splash screen to Toradex i.MX7D Colibri board
Date: Wed, 26 Nov 2025 18:54:48 +0100	[thread overview]
Message-ID: <DEITI8FI29LO.GOPV4GAORCZD@bootlin.com> (raw)
In-Reply-To: <20251126115931.GA26872@francesco-nb>

Hello Francesco,
On Wed Nov 26, 2025 at 12:59 PM CET, Francesco Dolcini wrote:
> [...]
>> -
>> -	return 0;
>> +	enable_pwm_clk(1, 0);
>> +	ret = pwm_init(0, 0, 0);
>> +	if (ret)
>> +		return ret;
>> +	ret = pwm_config(0, 0, 6666666);
>
> You are setting a period here for the PWM backlight (150Hz?),
> considering that colibri imx7 is a SoM, e.g. there is no actual display
> part of it, is this number generic enough?

Indeed there isn't, however for my tests I used the Toradex Colibri
Evaluation Board with the Toradex 7 inch Capacitive Touch Display [1] that is
meant to be used with the Colibri Evaluation Board.
This display typically uses a 150Hz PWM for its backlight so I chose this
value.
However there the pwm_config configure a 150Hz PWM with 0ns duty cycle so
in fact, no matter the frequency, this pin will act as an always off GPIO.

1: https://docs.toradex.com/104497-7-inch-parallel-capacitive-touch-display-800x480-datasheet.pdf

Thomas

  reply	other threads:[~2025-11-26 17:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-25 23:41 [PATCH 0/5] i.MX7 Splash Screen and PWM fixes Thomas Bonnefille
2025-11-25 23:41 ` [PATCH 1/5] drivers: video: mxsfb: Use kconfig VIDEO_REMOVE to remove video Thomas Bonnefille
2025-11-25 23:41 ` [PATCH 2/5] arm: include: imx7: rename PWM registers to match driver name Thomas Bonnefille
2025-11-25 23:41 ` [PATCH 3/5] mx7: clock: add pwm enabling clock function Thomas Bonnefille
2025-11-25 23:41 ` [PATCH 4/5] pwm: imx: allow i.MX7 to use PWM3 and PWM4 Thomas Bonnefille
2025-11-25 23:41 ` [PATCH 5/5] board: toradex: add splash screen to Toradex i.MX7D Colibri board Thomas Bonnefille
2025-11-26 11:59   ` Francesco Dolcini
2025-11-26 17:54     ` Thomas Bonnefille [this message]
2025-11-28 11:27       ` Francesco Dolcini
2025-11-28 11:29   ` Francesco Dolcini
2025-12-01 17:16   ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DEITI8FI29LO.GOPV4GAORCZD@bootlin.com \
    --to=thomas.bonnefille@bootlin.com \
    --cc=ag.dev.uboot@gmail.com \
    --cc=festevam@gmail.com \
    --cc=francesco.dolcini@toradex.com \
    --cc=francesco@dolcini.it \
    --cc=miquel.raynal@bootlin.com \
    --cc=sbabic@nabladev.com \
    --cc=sjg@chromium.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-imx@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.