From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "Peter Novak" <seimun018r@gmail.com>, <ojeda@kernel.org>,
<alex.gaynor@gmail.com>
Cc: <rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH] rust: use consistent backtick formatting for NULL in docs
Date: Mon, 01 Dec 2025 12:29:39 +0900 [thread overview]
Message-ID: <DEMK8K1I3FFY.27ERA2LKI7MYB@nvidia.com> (raw)
In-Reply-To: <20251130211233.367946-1-seimun018r@gmail.com>
On Mon Dec 1, 2025 at 6:12 AM JST, Peter Novak wrote:
> Some doc comments use `NULL` while others use plain NULL.
> This patch makes it consistent by adding backticks everywhere,
> matching the majority of existing usage.
>
> This is my first kernel patch - just getting familiar with
> the contribution process.
>
> Signed-off-by: Peter Novak <seimun018r@gmail.com>
This looks like a pretty good first patch! :)
Just make sure to put the meta-comments (the "This is my first kernel
patch" sentence) below a `---` line so they don't get picked up in the
git log. See [1] for an example.
With that sentence removed (which I believe will be done when applying
if no other fixes are required),
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
I have double-checked with `rg '\/\/\/.*NULL'` from the `rust` directory
and this indeed appears to address all cases.
[1] https://lore.kernel.org/rust-for-linux/20251124-bounded_fix-v1-1-d8e34e1c727f@nvidia.com/
next prev parent reply other threads:[~2025-12-01 3:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-30 21:12 [PATCH] rust: use consistent backtick formatting for NULL in docs Peter Novak
2025-12-01 3:29 ` Alexandre Courbot [this message]
2026-01-18 22:14 ` Miguel Ojeda
2026-01-18 23:07 ` Danilo Krummrich
2026-01-19 7:09 ` David Gow
2026-01-23 2:21 ` Stephen Boyd
2026-01-26 5:03 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DEMK8K1I3FFY.27ERA2LKI7MYB@nvidia.com \
--to=acourbot@nvidia.com \
--cc=alex.gaynor@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=seimun018r@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.