From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F22129DB8F for ; Thu, 4 Dec 2025 17:07:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764868068; cv=none; b=LO2vgwmeTGkmN830tZy8/goVAMzFr1BfdqtOisMNK3dyvnbCGNNNMkxER+K2sCU1lbRituIuwg67lkv3zl9VKFb7dZb8mrIlOVyS8ppRnW9WRLvd+PLctKuJjSt077QVPdmHdckD8FDEmXs4vwwPc/XEh8CszWtJEySIcpjbdKQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764868068; c=relaxed/simple; bh=3ngML/Jq7dnnl6CYo/sspTAs/M19EnvjGfsPsQ9/WIY=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=X9lZBAjqthZO1Oq+qIXAUwpsDyv/pCcb7neK6zJApTvUpnPzauYtyCYNEmH7lr+zViK2Pk/MC2kNYPHEdQcdDBPi+UWuizaelAIFWeyQ0ZiypAYjQrmKHMupSbkzd+00dB3Bad/FIzlxnOSODr1q0VeUKhQZzsNA+VbcCq6BXvY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lmqi6RQK; arc=none smtp.client-ip=209.85.128.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lmqi6RQK" Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-787f586532bso10351697b3.1 for ; Thu, 04 Dec 2025 09:07:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1764868066; x=1765472866; darn=lists.linux.dev; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=dodiYRijYOTY+6wzJ7p3kpwOxeuNqeJeiUwFQNKlPr0=; b=lmqi6RQKfrcwrC2U14/hPD3LI5mgcz2cskxxXbBhnmWsRktXMwdZcLmz6078tOQtzJ 1NJBEeefABy1Hnu01wWJIDIQ5/Z1aNUYZFklVizfQCOBfzLrsGmN2dHbfbtNbonVSvMo EZhaZt38HUr62N7e1gMATss+RnXYwU54qZ33Z/3JocI1BfcToa4zIQcZeTJks1HUook+ fZhiK3k5lxxuIaBwwMr2W9x2fZMVwzJdpAz4BbAx7FBYp9pvEy3ioe34E2J2QjvkIPXe OjG1oxfj1bXc0FY/y3At/rOn0eyEl7TIeaTo1XC9eXUgsymUzUdS/OnRZOc3318z8v1n v6lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764868066; x=1765472866; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=dodiYRijYOTY+6wzJ7p3kpwOxeuNqeJeiUwFQNKlPr0=; b=U0D6pj0ZX19Ns6TBGxQt+FrtF96qkAOwu5bWj+spptaZ9D1NaWyGezZO2yMIQ1VLve nzKzalyyEt3FnxXbLqQdQ6rRIHpJ7fS/YcSP0+zRrzq8eCtojtwnCaISswHc/pMH+GDt ucHTu9VfdXWVLtb5fdcBWiVxuKLf7Jr58i6uUT955tX+g3OX5QWTGUJtILxIGIqH3B9S 52pGCxi2fO2ZPTaF4OIQKjCRrwfgCon9a9O9bKIx4m8NZfxtZG26kbxpEMCA2bl+kPwB aruJbnx9Fysk6CYN/MJWhGGnmoDwzzQwhDcwbq/3kIXbiOH58FigCaC0Vy2K5THFoDKg Z6gA== X-Forwarded-Encrypted: i=1; AJvYcCWmMHns6Ka1b5RYIkOqZNC/FB4Ci8DmcBHGvtQEJv9gEUG7M+TGMQnJ2uzF4Yz/LC9G+YtoFJpbdMr1V3NytOA=@lists.linux.dev X-Gm-Message-State: AOJu0Yxr0YK66N/C55Ql5Peqcuw7dc0qQrNGs+g5ooy3V7pK55bQxs2b 8ZTgrIJxhpZIS4CUKIzA+UVdFeLt8gkauKNQ24vEVkREa0WUoZmqgYe0 X-Gm-Gg: ASbGncunKc75U7FvDA4rSJb/xHJBWczWsQOb6M8cKahSF8SoYfb8l/htDLRiLO6Fczm dyWOWaxwC6jIaj7tU2y3XGHhDnOWjqy8fS64mbo0Vota6JTEBvA33kZsJDuNkZkwEA3bv14Eb4Z bPeWq9plS/Ws7vulmXT76ZoOR41f3Kpr/1HLECa+heusamk7KI8eBERl3rnwNQfFPa5F5RBLKfC 2Yit4BtqGN+az7nyURqZcvb/Jok9j3CYxu9ePEbdzHjGbjgM12ssklU+mwqDxmgE2WhE0GGHHeW S7UjdkYIumvsX7ZWnA6+gOYg/ul2BA32AGIW0uPlsf+1inZvx+i59UbWSIe3xRlgGa/lWxakqLx +CvouATy9OwWcutvHvkwU/tAHlQiGZiHfUlUBwZTPmkNuZSqSZCsZtHOgaG8qaGmiy1xmHVDZVu avDdavSg== X-Google-Smtp-Source: AGHT+IEex4E/v8syAVkEMByk59a7h0uIcRlr5mbQVnRjs06eIXWWVY8PiZvvFzioBr5dCBQlvKANaw== X-Received: by 2002:a05:690e:250f:20b0:644:444f:3bb7 with SMTP id 956f58d0204a3-644444f40ccmr429565d50.5.1764868066048; Thu, 04 Dec 2025 09:07:46 -0800 (PST) Received: from localhost ([2800:bf0:4580:3149:7d4:54b1:c444:6f2f]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6443f2abfd4sm840396d50.5.2025.12.04.09.07.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Dec 2025 09:07:45 -0800 (PST) Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 04 Dec 2025 12:07:43 -0500 Message-Id: Cc: =?utf-8?q?Nuno_S=C3=A1?= , "Andy Shevchenko" , "Guenter Roeck" , "Jonathan Cameron" , , , Subject: Re: [PATCH RFC 5/6] iio: health: max30102: Use cleanup.h for IIO locks From: "Kurt Borja" To: "David Lechner" , "Kurt Borja" , "Andy Shevchenko" , "Lars-Peter Clausen" , "Michael Hennerich" , "Jonathan Cameron" , "Benson Leung" , "Antoniu Miclaus" , "Gwendal Grignou" , "Shrikant Raskar" , "Per-Daniel Olsson" X-Mailer: aerc 0.21.0-0-g5549850facc2 References: <20251203-lock-impr-v1-0-b4a1fd639423@gmail.com> <20251203-lock-impr-v1-5-b4a1fd639423@gmail.com> In-Reply-To: On Wed Dec 3, 2025 at 4:52 PM -05, David Lechner wrote: > On 12/3/25 1:18 PM, Kurt Borja wrote: >> Simplify and drop "hacky" busy-waiting code in max30102_read_raw() by >> using scoped_guard(). >>=20 >> Signed-off-by: Kurt Borja >> --- >> drivers/iio/health/max30102.c | 24 +++++++----------------- >> 1 file changed, 7 insertions(+), 17 deletions(-) >>=20 >> diff --git a/drivers/iio/health/max30102.c b/drivers/iio/health/max30102= .c >> index 678720102f2b..c642842cb5fb 100644 >> --- a/drivers/iio/health/max30102.c >> +++ b/drivers/iio/health/max30102.c >> @@ -24,6 +24,7 @@ >> #include >> #include >> #include >> +#include >> =20 >> #define MAX30102_DRV_NAME "max30102" >> #define MAX30102_PART_NUMBER 0x15 >> @@ -468,6 +469,7 @@ static int max30102_read_raw(struct iio_dev *indio_d= ev, >> { >> struct max30102_data *data =3D iio_priv(indio_dev); >> int ret =3D -EINVAL; >> + bool direct_en; >> =20 >> switch (mask) { >> case IIO_CHAN_INFO_RAW: >> @@ -475,25 +477,13 @@ static int max30102_read_raw(struct iio_dev *indio= _dev, >> * Temperature reading can only be acquired when not in >> * shutdown; leave shutdown briefly when buffer not running >> */ >> -any_mode_retry: >> - if (!iio_device_claim_buffer(indio_dev)) { >> - /* >> - * This one is a *bit* hacky. If we cannot claim buffer >> - * mode, then try direct mode so that we make sure >> - * things cannot concurrently change. And we just keep >> - * trying until we get one of the modes... >> - */ >> - if (!iio_device_claim_direct(indio_dev)) >> - goto any_mode_retry; >> + scoped_guard(iio_device_claim, indio_dev) { > > scoped_guard() is sketchy in switch statements because there is > a hidden for loop. If someone came along later and put a break; > inside of the scope, it would break out of the hidden for loop > rather than the apparent switch case! > > Besides that, it adds extra indent that we could avoid. > >> + direct_en =3D !iio_buffer_enabled(indio_dev); >> =20 >> - ret =3D max30102_get_temp(data, val, true); >> - iio_device_release_direct(indio_dev); >> - } else { >> - ret =3D max30102_get_temp(data, val, false); >> - iio_device_release_buffer(indio_dev); >> + ret =3D max30102_get_temp(data, val, direct_en); >> + if (ret) >> + return ret; >> } >> - if (ret) >> - return ret; >> =20 >> ret =3D IIO_VAL_INT; >> break; >>=20 > > I would write the whole function like this: > > static int max30102_read_raw(struct iio_dev *indio_dev, > struct iio_chan_spec const *chan, > int *val, int *val2, long mask) > { > struct max30102_data *data =3D iio_priv(indio_dev); > int ret; > > switch (mask) { > case IIO_CHAN_INFO_RAW: { > /* > * Temperature reading can only be acquired when not in > * shutdown; leave shutdown briefly when buffer not running > */ > guard(iio_device_claim)(indio_dev); AFAIK you can't guard() inside switch-case blocks. I don't know the exact reason, but it has to be scoped_guard(). > ret =3D max30102_get_temp(data, val, !iio_buffer_enabled(indio_dev)); > if (ret) > return ret; > > return IIO_VAL_INT; > } > case IIO_CHAN_INFO_SCALE: > *val =3D 1000; /* 62.5 */ > *val2 =3D 16; > return IIO_VAL_FRACTIONAL; > default: > return -EINVAL; > } > } > > Could also simplify things further by moving the call to iio_buffer_enabl= ed() > into max30102_get_temp(). I'll do it like this if this survives v2. --=20 ~ Kurt