Re: [PATCH i-g-t 1/2] RFC: chamelium/kms_chamelium_hpd: add helper function to select connector port

[Sebastian Brzezinka <sebastian.brzezinka@intel.com>]

Hi Moahmmed

On Fri Dec 5, 2025 at 8:46 AM CET, Moahmmed Bilal wrote:
> From: Mohammed Bilal <mohammed.bilal@intel.com>
>
> Introduce a new helper function get_port() which returns the
> chamelium_port matching the requested connector type.
> The helper iterates through the available ports and
> returns the first match, or NULL if no matching connector is found.
>
> Signed-off-by: Mohammed Bilal <mohammed.bilal@intel.com>
> ---
>  tests/chamelium/kms_chamelium_hpd.c | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>
> diff --git a/tests/chamelium/kms_chamelium_hpd.c b/tests/chamelium/kms_chamelium_hpd.c
> index 161f494e9..3c8af63bd 100644
> --- a/tests/chamelium/kms_chamelium_hpd.c
> +++ b/tests/chamelium/kms_chamelium_hpd.c
> @@ -158,6 +158,21 @@ enum test_modeset_mode {
>  	TEST_MODESET_OFF,
>  };
>  
> +__maybe_unused
This function is used in the next patch. If the use of __maybe_unused here
is intended to bypass current CI warnings, please remove this attribute in
the next patch to avoid confusion.

> +static struct chamelium_port *get_port(struct chamelium_port **ports,
> +				       int port_count, int connector_type)
It's a small detail, but please use uint for port_count.

BR
Seba