Re: [PATCH 11/14] greybus: cpc: honour remote's RX window

["Yacin Belmihoub-Martel" <yacin.belmihoub-martel@silabs.com>]

On Fri Dec 12, 2025 at 11:13 AM EST, Damien Riégel wrote:
> +u8 cpc_header_get_frames_acked_count(u8 seq, u8 ack)
> +{
> +	u8 frames_acked_count;
> +
> +	/* Find number of frames acknowledged with ACK number. */
> +	if (ack > seq) {
> +		frames_acked_count = ack - seq;
> +	} else {
> +		frames_acked_count = 256 - seq;
> +		frames_acked_count += ack;
> +	}
> +
> +	return frames_acked_count;
> +}

[nit]
As stated in the RFC, this can be simplified to `return ack - seq;`,
since both `ack`, `seq` and the return value are `u8`.

Thanks,
-- 
Yacin Belmihoub-Martel
Silicon Laboratories