From: Andrea Cervesato via ltp <ltp@lists.linux.it>
To: "Martin Doucha" <mdoucha@suse.cz>, <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH] tst_detach_device: Clear leftover partitions
Date: Tue, 16 Dec 2025 13:19:41 +0100 [thread overview]
Message-ID: <DEZMWJMK4KV0.47URP2UHSTZR@suse.com> (raw)
In-Reply-To: <b4bb06e0-290e-45c0-8a82-194b91256b2b@suse.cz>
On Tue Dec 16, 2025 at 1:16 PM CET, Martin Doucha wrote:
> On 12/16/25 13:13, Andrea Cervesato wrote:
> > In general the code looks good, but the sentence "Some kernels have a
> > race condition during loop device release" sounds like a kernel bug
> > that we are working around with this feature. I know probably this
> > is not the case, but if I read the sentence this is what I guess.
>
> Yes, this is a kernel bug and yes, we are working around it. But the
> workaround is not there to hide it, it's there to flag the bug in the
> appropriate test which triggered it and prevent other unrelated tests
> from failing. Think of it as extra thorough post-test environment cleanup.
Ok thanks, now it's more clear. It would be nice to add this comment to
the commit message.
Reviewed-by: Andrea Cervesato <andrea.cervesato@suse.com>
--
Andrea Cervesato
SUSE QE Automation Engineer Linux
andrea.cervesato@suse.com
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-12-16 12:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-12 10:40 [LTP] [PATCH] tst_detach_device: Clear leftover partitions Martin Doucha
2025-12-12 14:39 ` Petr Vorel
2025-12-16 12:13 ` Andrea Cervesato via ltp
2025-12-16 12:16 ` Martin Doucha
2025-12-16 12:19 ` Andrea Cervesato via ltp [this message]
2025-12-18 13:11 ` Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DEZMWJMK4KV0.47URP2UHSTZR@suse.com \
--to=ltp@lists.linux.it \
--cc=andrea.cervesato@suse.com \
--cc=mdoucha@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.