All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Danilo Krummrich" <dakr@kernel.org>
To: "Marko Turk" <mt@markoturk.info>
Cc: <bhelgaas@google.com>, <kwilczynski@kernel.org>,
	<miguel.ojeda.sandonis@gmail.com>, <dirk.behme@de.bosch.com>,
	<linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH 1/2] rust: pci: document Bar's endianness conversion
Date: Wed, 17 Dec 2025 17:23:36 +0100	[thread overview]
Message-ID: <DF0MPUGED5JR.1JBLR4H5IF1TG@kernel.org> (raw)
In-Reply-To: <20251210112503.62925-1-mt@markoturk.info>

On Wed Dec 10, 2025 at 12:25 PM CET, Marko Turk wrote:
> Document that the Bar's MMIO backend always assumes little-endian
> devices and that its operations automatically convert to CPU endianness.
>
> Signed-off-by: Marko Turk <mt@markoturk.info>
> Link: https://lore.kernel.org/lkml/DE7F6RR1NAKW.3DJYO44O73941@kernel.org/
> ---
>  rust/kernel/pci/io.rs | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/rust/kernel/pci/io.rs b/rust/kernel/pci/io.rs
> index 0d55c3139b6f..bfa9df9e9bb9 100644
> --- a/rust/kernel/pci/io.rs
> +++ b/rust/kernel/pci/io.rs
> @@ -18,9 +18,12 @@
>  
>  /// A PCI BAR to perform I/O-Operations on.
>  ///
> +/// I/O backend assumes that the device is little-endian and will automatically
> +/// convert from little-endian to CPU endianness.
> +///
>  /// # Invariants
>  ///
> -/// `Bar` always holds an `IoRaw` inststance that holds a valid pointer to the start of the I/O
> +/// `Bar` always holds an `IoRaw` instance that holds a valid pointer to the start of the I/O

Can you please send this typo fix as a separate patch?

No need to resend this one though, I can change it up on my end.

- Danilo

  parent reply	other threads:[~2025-12-17 16:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-10 11:25 [PATCH 1/2] rust: pci: document Bar's endianness conversion Marko Turk
2025-12-10 11:25 ` [PATCH 2/2] samples: rust: fix endianness issue in rust_driver_pci Marko Turk
2025-12-10 14:10   ` Dirk Behme
2025-12-17 17:11   ` Danilo Krummrich
2025-12-17 16:23 ` Danilo Krummrich [this message]
2025-12-17 17:06 ` [PATCH 1/2] rust: pci: document Bar's endianness conversion Danilo Krummrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DF0MPUGED5JR.1JBLR4H5IF1TG@kernel.org \
    --to=dakr@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=dirk.behme@de.bosch.com \
    --cc=kwilczynski@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=mt@markoturk.info \
    --cc=rust-for-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.