From: "Danilo Krummrich" <dakr@kernel.org>
To: "Marko Turk" <mt@markoturk.info>
Cc: <dirk.behme@de.bosch.com>, <linux-pci@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH 2/2] rust: pci: fix typo in Bar struct's comment
Date: Sat, 03 Jan 2026 16:24:17 +0100 [thread overview]
Message-ID: <DFF23OTZRIDS.2PZIV7D8AHWFA@kernel.org> (raw)
In-Reply-To: <20260103143119.96095-2-mt@markoturk.info>
On Sat Jan 3, 2026 at 3:31 PM CET, Marko Turk wrote:
> inststance -> instance
It's trivial in this case, but we usually write at least something along the
lines of "Fix a typo in the doc-comment of the Bar structure: 'inststance ->
instance'."
Please also add a corresponding Fixes: tag.
> Signed-off-by: Marko Turk <mt@markoturk.info>
> ---
> rust/kernel/pci/io.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rust/kernel/pci/io.rs b/rust/kernel/pci/io.rs
> index 0d55c3139b6f..fba746c4dc5d 100644
> --- a/rust/kernel/pci/io.rs
> +++ b/rust/kernel/pci/io.rs
> @@ -20,7 +20,7 @@
> ///
> /// # Invariants
> ///
> -/// `Bar` always holds an `IoRaw` inststance that holds a valid pointer to the start of the I/O
> +/// `Bar` always holds an `IoRaw` instance that holds a valid pointer to the start of the I/O
> /// memory mapped PCI BAR and its size.
> pub struct Bar<const SIZE: usize = 0> {
> pdev: ARef<Device>,
> --
> 2.51.0
next prev parent reply other threads:[~2026-01-03 15:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-03 14:31 [PATCH 1/2] rust: io: fix Bar reference in Io struct's comment Marko Turk
2026-01-03 14:31 ` [PATCH 2/2] rust: pci: fix typo in Bar " Marko Turk
2026-01-03 15:24 ` Danilo Krummrich [this message]
2026-01-03 15:38 ` Dirk Behme
2026-01-03 21:16 ` Marko Turk
2026-01-04 12:45 ` Miguel Ojeda
2026-01-04 14:08 ` Danilo Krummrich
2026-01-04 18:30 ` Miguel Ojeda
2026-01-05 6:25 ` Greg KH
2026-01-05 10:39 ` Miguel Ojeda
2026-01-05 12:38 ` Danilo Krummrich
2026-01-03 15:22 ` [PATCH 1/2] rust: io: fix Bar reference in Io " Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFF23OTZRIDS.2PZIV7D8AHWFA@kernel.org \
--to=dakr@kernel.org \
--cc=dirk.behme@de.bosch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mt@markoturk.info \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.