Re: [PATCH v2 2/6] dm: core: lists_bind_fdt: Replace found variable

["Markus Schneider-Pargmann" <msp@baylibre.com>]

[-- Attachment #1: Type: text/plain, Size: 2283 bytes --]

Hi Simon,

On Fri Jan 9, 2026 at 12:32 PM CET, Simon Glass wrote:
> Hi Markus,
>
> On Thu, 8 Jan 2026 at 04:17, Markus Schneider-Pargmann (TI.com)
> <msp@baylibre.com> wrote:
>>
>> 'found' is only used at the end of the function to print a debug
>> message. No need to maintain a variable if we can just return 0
>> immediately when a driver was bound successfully.
>>
>> Signed-off-by: Markus Schneider-Pargmann (TI.com) <msp@baylibre.com>
>> ---
>>  drivers/core/lists.c | 5 ++---
>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/core/lists.c b/drivers/core/lists.c
>> index 52ba6c7bfa007b660b854de62c97ad3c1761f1a5..9d1ca38212ee7f53b8894f964f096611c8ec20a5 100644
>> --- a/drivers/core/lists.c
>> +++ b/drivers/core/lists.c
>> @@ -204,7 +204,6 @@ int lists_bind_fdt(struct udevice *parent, ofnode node, struct udevice **devp,
>>         const struct udevice_id *id;
>>         struct driver *entry;
>>         struct udevice *dev;
>> -       bool found = false;
>>         const char *name, *compat_list, *compat;
>>         int compat_length, i;
>>         int ret = 0;
>> @@ -275,14 +274,14 @@ int lists_bind_fdt(struct udevice *parent, ofnode node, struct udevice **devp,
>>                                 ret);
>>                         return log_msg_ret("bind", ret);
>>                 } else {
>> -                       found = true;
>>                         if (devp)
>>                                 *devp = dev;
>> +                       return 0;
>>                 }
>>                 break;
>>         }
>>
>> -       if (!found && ret != -ENODEV)
>> +       if (ret != -ENODEV)
>>                 log_debug("No match for node '%s'\n", name);
>>
>>         return 0;
>>
>> --
>> 2.51.0
>>
>
> I like to have a single successful return at the end of each function
> so that it is easier to follow what is going on. But since you wrote
> this patch:
>
> Reviewed-by: Simon Glass <simon.glass@canonical.com>

Thanks for reviewing. If you prefer I can redesign this as well. But
also note that the function already has two early return 0. One if the
device does not have a compatible list and the other for pre_reloc_only
if pre-relocation is skipped.

Best
Markus


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 289 bytes --]