From: "Danilo Krummrich" <dakr@kernel.org>
To: "Gui-Dong Han" <hanguidong02@gmail.com>
Cc: <gregkh@linuxfoundation.org>, <rafael@kernel.org>,
<linux-kernel@vger.kernel.org>, <baijiaju1990@gmail.com>,
"Qiu-ji Chen" <chenqiuji666@gmail.com>, <2045gemini@gmail.com>
Subject: Re: [PATCH v3] driver core: fix use-after-free of driver_override via driver_match_device()
Date: Tue, 13 Jan 2026 15:20:04 +0100 [thread overview]
Message-ID: <DFNIZZ4P4DV4.3972S35CYSL89@kernel.org> (raw)
In-Reply-To: <CALbr=LYmatNKhgDDbYUw=9_VLzhu9D39fBs1yMQLJE=eAaeRDw@mail.gmail.com>
On Tue Jan 13, 2026 at 3:05 PM CET, Gui-Dong Han wrote:
> I see your point now. I agree that we should frame this as fixing the
> inconsistent locking guarantee of match() callbacks. This is exactly
> what the code changes in my patch implement. The fix for
> driver_override UAF is a natural result of this consistency.
>
> I plan to send a v4 to update the subject and commit log to focus on
> enforcing consistent locking.
Great, thanks!
> For the code comment, I will remove the mention of
> driver_set_override. Do you prefer /* Ensure consistent locking for
> match() callbacks */ or simply no comment?
I think both is fine, the comment probably doesn't hurt.
> Regarding the larger refactoring of driver_override, I am willing to
> look into it as a follow-up task.
Thanks!
prev parent reply other threads:[~2026-01-13 14:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-27 14:57 [PATCH v3] driver core: fix use-after-free of driver_override via driver_match_device() Gui-Dong Han
2026-01-13 9:55 ` Danilo Krummrich
2026-01-13 11:08 ` Danilo Krummrich
2026-01-13 12:42 ` Gui-Dong Han
2026-01-13 13:34 ` Danilo Krummrich
2026-01-13 13:43 ` Rafael J. Wysocki
2026-01-13 14:05 ` Gui-Dong Han
2026-01-13 14:20 ` Danilo Krummrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFNIZZ4P4DV4.3972S35CYSL89@kernel.org \
--to=dakr@kernel.org \
--cc=2045gemini@gmail.com \
--cc=baijiaju1990@gmail.com \
--cc=chenqiuji666@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hanguidong02@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.