From: "Alexis Lothoré" <alexis.lothore@bootlin.com>
To: "Alan Maguire" <alan.maguire@oracle.com>,
"Alexis Lothoré" <alexis.lothore@bootlin.com>,
ast@kernel.org
Cc: <daniel@iogearbox.net>, <andrii@kernel.org>,
<martin.lau@linux.dev>, <eddyz87@gmail.com>, <song@kernel.org>,
<yonghong.song@linux.dev>, <john.fastabend@gmail.com>,
<kpsingh@kernel.org>, <sdf@fomichev.me>, <haoluo@google.com>,
<jolsa@kernel.org>, <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf] selftests/bpf: Support when CONFIG_VXLAN=m
Date: Mon, 19 Jan 2026 14:00:34 +0100 [thread overview]
Message-ID: <DFSL2DHCSLNU.1640Y190S8S1Q@bootlin.com> (raw)
In-Reply-To: <87900b12-c836-4692-ad7d-b1997df806d8@oracle.com>
Hi Alan,
On Fri Jan 16, 2026 at 10:32 AM CET, Alan Maguire wrote:
> On 16/01/2026 08:30, Alexis Lothoré wrote:
>> Hello,
>>
>> On Thu Jan 15, 2026 at 5:34 PM CET, Alan Maguire wrote:
>>> If CONFIG_VXLAN is 'm', struct vxlanhdr will not be in vmlinux.h.
>>> Add a ___local variant to support cases where vxlan is a module.
>>
>> Just a naive question: for ebpf selftests, aren't we assuming a
>> dependency on a "fixed" kernel configuration (ie
>> tools/testing/selftests/bpf/{config,config.vm,config.<arch}), which
>> enables most of the features as built-in ?
>>
>
> It's a good question - my take here is that we also need to remember
> that most folks interactions with BPF happen via distro kernels. Most distros
> tend to modularize their configs more extensively, and they also want to use
> the BPF selftests to qualify the particular config combination they have
> so that they can be sure that users have a good BPF experience.
> Often issues arise from this, and distro folks either report or post
> fixes. This is all good, so if the only cost is a bit more flexibility
> in the test environment, I'd say it's well worth supporting that. In
> particular blockers to selftests compilation cause problems for this
> process.
>
> There are of course cases where having a very old toolchain or a highly
> incompatible configuration that aren't supportable, but in general where there
> is low-hanging fruit in making tests a bit more flexible, it's worth doing I
> think.
With a bit of delay: ok, thanks for your input. To clarify, my point was
not really about challenging your change but rather that I was not sure
about the policy here; supporting only the CI selftests configuration,
VS supporting other kernel configurations like distro configs (at the
cost of duplicating a bit kernel data strutures definitions).
Thanks,
Alexis
--
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2026-01-19 13:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 16:34 [PATCH bpf] selftests/bpf: Support when CONFIG_VXLAN=m Alan Maguire
2026-01-16 8:30 ` Alexis Lothoré
2026-01-16 9:32 ` Alan Maguire
2026-01-19 13:00 ` Alexis Lothoré [this message]
2026-01-19 17:13 ` Alexei Starovoitov
2026-01-16 23:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFSL2DHCSLNU.1640Y190S8S1Q@bootlin.com \
--to=alexis.lothore@bootlin.com \
--cc=alan.maguire@oracle.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.