From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 32AF9D29C33 for ; Mon, 19 Jan 2026 15:50:20 +0000 (UTC) Received: from kara.freedesktop.org (unknown [131.252.210.166]) by gabe.freedesktop.org (Postfix) with ESMTPS id B742010E4B5; Mon, 19 Jan 2026 15:50:18 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="Otq9VxZx"; dkim-atps=neutral Received: from kara.freedesktop.org (localhost [127.0.0.1]) by kara.freedesktop.org (Postfix) with ESMTP id 4F64644CA9; Mon, 19 Jan 2026 15:41:36 +0000 (UTC) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=lists.freedesktop.org; s=20240201; t=1768837296; b=XxOgBR0BLQ6L/vvLzqKCRGQg3nacRIj/7nxV7xLkqPurw6yjqitPcmTseOP5vZVDY5onJ Muo56Qk4WKEXFnfcNHoaq6sF2tqISZ/uHSQ0EGraejQBk1SQIu7QG7izIhoZ4CNBpOvC9Pe USFoHtgWYLUhgFcd/M2spm8JkCxJ4Rw4G4xXhxg0ZsYZ6Hu8qoTvNYpcBST9RSmBIEkw1u8 +KINGR1OANlqAQqujbn2qTXlraO2Lz8aXLwOEqz5b4ni4QLQd6ecrfnsxOwC/48c6LejWxf vQzr7z8zzCUX/R7lW4llG2+NGAHgjP/Vw/gNoUi0mWGpfxLAWbLzoCd+3fCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=lists.freedesktop.org; s=20240201; t=1768837296; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=W7rT9hHYL8T7lprygSHgm5zOCb0EvFYDb7jfwrRlIXY=; b=ka+cH4WaxHQYRZNyum/YKCLQwoDVHCclZhprwgsVkfd6NDakxyG7St0cRbOizxNFKwBnl 2Z5GcbTbWienaei0HUF6TrYehfjU/1He7JrbN7mHV3SEsuOIm/Q9pIrF6I8JIEZhJ6gYLh1 XVLO2Ub6t8qXVRzai5SDJ6aSPO3FBFmFR2ZOZP71ozM1RSA6ciw/CtvCXZ52Two7oV1XLG9 lFx1GUHpbvvTlFa+KZVuFksoqIeWPM0VyE3BKX6HvSu06YDsc1Tau8i1XM4Ma5DUmKow/Kx S964uMPdYzjzaBAAkZ3y8KXDXJkKaFRx8wIHrIgPbeeeFMBbWpxzvBhr2s2Q== ARC-Authentication-Results: i=1; mail.freedesktop.org; dkim=pass header.d=kernel.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=kernel.org policy.dmarc=quarantine Authentication-Results: mail.freedesktop.org; dkim=pass header.d=kernel.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=kernel.org policy.dmarc=quarantine Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by kara.freedesktop.org (Postfix) with ESMTPS id 86A2644BDC for ; Mon, 19 Jan 2026 15:41:33 +0000 (UTC) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id BCDE910E4AE; Mon, 19 Jan 2026 15:50:15 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 1D28042D65; Mon, 19 Jan 2026 15:50:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2ADE4C19423; Mon, 19 Jan 2026 15:50:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768837815; bh=4bjc5aajcuzBHvXCPRPtvjsISc8dexTvQe1HeiR9z9k=; h=Date:From:Subject:Cc:To:References:In-Reply-To:From; b=Otq9VxZxTCDWO7NP/o5dZBtU+J9r7kwGjWWaBS5ZuQFvXYQW6QmPZYzv6lLEZSEh7 eIf8etXkH7aluEctAwBnFQfwWBGmNCS8EYcpQzSyDpaHdYfzFmM5MAa6rYQL1pr67F vA23Z9df91ftloLSZ85httOC3PIqxdUsZT2T3ETaEd8GZkLQaSS/6hPMGn5teV0hjN NE0tOqrwZK84qi+OCVdWaScwcK/9jHBVoGnvrpXbYxC0h9bKJzJbnzoRzhK6TLuTzt /jPktw9xMgoQVbVtx6ada4eBunVBCMMj7TeBfjmxbDJPYBfT7e/wUDTdUk0aYLTWpG MnDLlyeo5vHPw== Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 19 Jan 2026 16:50:10 +0100 Message-Id: From: "Danilo Krummrich" Subject: Re: [PATCH v2 07/10] gpu: nova-core: firmware: fwsec: do not require bound device when unneeded To: "Alexandre Courbot" References: <20251216-nova-misc-v2-0-dc7b42586c04@nvidia.com> <20251216-nova-misc-v2-7-dc7b42586c04@nvidia.com> In-Reply-To: <20251216-nova-misc-v2-7-dc7b42586c04@nvidia.com> Message-ID-Hash: SFHLOQ4VPYIEM3IMGZG5LHW226Y75TMG X-Message-ID-Hash: SFHLOQ4VPYIEM3IMGZG5LHW226Y75TMG X-MailFrom: dakr@kernel.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: Alice Ryhl , Simona Vetter , Alistair Popple , Joel Fernandes , Eliot Courtney , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: Nouveau development list Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue Dec 16, 2025 at 5:27 AM CET, Alexandre Courbot wrote: > /// Loads the FWSEC firmware into `falcon` and execute it. > - pub(crate) fn run( > - &self, > - dev: &Device, > - falcon: &Falcon, > - bar: &Bar0, Hm..the method also takes a &pci::Bar, so its either called from a bound co= ntext or within a Revocable critical section. Leaving the other argument as &Device makes it obvious which one it = is (and should be). > - ) -> Result<()> { > + pub(crate) fn run(&self, dev: &Device, falcon: &Falcon, bar: &B= ar0) -> Result<()> { > // Reset falcon, load the firmware, and run it. > falcon > .reset(bar) > > --=20 > 2.52.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9ED0938BF8F; Mon, 19 Jan 2026 15:50:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768837816; cv=none; b=GV3AAo2gjIuHfCYUN2rFg6qPKbu8DwC2MeLubB7TSBhFtGHQ2Ej2w5EXs1cFDl6W3zoW9eHamaQe9rj7Hm31tMfyIZtVYHzYbufGctucayahwXnB2t18fqqIMfSqrRoKFNQbkMN+FXUqcEHaEBultX+7WLhlZXoS0FuWhHfEL6A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768837816; c=relaxed/simple; bh=4bjc5aajcuzBHvXCPRPtvjsISc8dexTvQe1HeiR9z9k=; h=Mime-Version:Content-Type:Date:Message-Id:From:Subject:Cc:To: References:In-Reply-To; b=dBmd10WpeuUQX+phw09JXWJff8g/p7D3ji9s5wPgblwH5Lv6WIJztKbU4aW71kpASyo4ydU3o5R70KH/cIdMNZ8d9/mdop74LUsVJiInrmYVr4vcLqrsGVR81L+Dozwstgz+x8C3ZEi7sqp0wB93EP/iKKvEeE3J5F6quBCpYq4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Otq9VxZx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Otq9VxZx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2ADE4C19423; Mon, 19 Jan 2026 15:50:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768837815; bh=4bjc5aajcuzBHvXCPRPtvjsISc8dexTvQe1HeiR9z9k=; h=Date:From:Subject:Cc:To:References:In-Reply-To:From; b=Otq9VxZxTCDWO7NP/o5dZBtU+J9r7kwGjWWaBS5ZuQFvXYQW6QmPZYzv6lLEZSEh7 eIf8etXkH7aluEctAwBnFQfwWBGmNCS8EYcpQzSyDpaHdYfzFmM5MAa6rYQL1pr67F vA23Z9df91ftloLSZ85httOC3PIqxdUsZT2T3ETaEd8GZkLQaSS/6hPMGn5teV0hjN NE0tOqrwZK84qi+OCVdWaScwcK/9jHBVoGnvrpXbYxC0h9bKJzJbnzoRzhK6TLuTzt /jPktw9xMgoQVbVtx6ada4eBunVBCMMj7TeBfjmxbDJPYBfT7e/wUDTdUk0aYLTWpG MnDLlyeo5vHPw== Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 19 Jan 2026 16:50:10 +0100 Message-Id: From: "Danilo Krummrich" Subject: Re: [PATCH v2 07/10] gpu: nova-core: firmware: fwsec: do not require bound device when unneeded Cc: "Alice Ryhl" , "David Airlie" , "Simona Vetter" , "John Hubbard" , "Alistair Popple" , "Joel Fernandes" , "Timur Tabi" , "Edwin Peer" , "Eliot Courtney" , , , , , "Lyude Paul" To: "Alexandre Courbot" References: <20251216-nova-misc-v2-0-dc7b42586c04@nvidia.com> <20251216-nova-misc-v2-7-dc7b42586c04@nvidia.com> In-Reply-To: <20251216-nova-misc-v2-7-dc7b42586c04@nvidia.com> On Tue Dec 16, 2025 at 5:27 AM CET, Alexandre Courbot wrote: > /// Loads the FWSEC firmware into `falcon` and execute it. > - pub(crate) fn run( > - &self, > - dev: &Device, > - falcon: &Falcon, > - bar: &Bar0, Hm..the method also takes a &pci::Bar, so its either called from a bound co= ntext or within a Revocable critical section. Leaving the other argument as &Device makes it obvious which one it = is (and should be). > - ) -> Result<()> { > + pub(crate) fn run(&self, dev: &Device, falcon: &Falcon, bar: &B= ar0) -> Result<()> { > // Reset falcon, load the firmware, and run it. > falcon > .reset(bar) > > --=20 > 2.52.0