From: Alejandro Vallejo <alejandro.garciavallejo@amd.com>
To: Jan Beulich <jbeulich@suse.com>, Teddy Astie <teddy.astie@vates.tech>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Jason Andryuk" <jason.andryuk@amd.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH 1/2] x86/svm: Add infrastructure for Bus Lock Threshold
Date: Wed, 21 Jan 2026 13:40:45 +0100 [thread overview]
Message-ID: <DFU9WAGCWK27.1UYPR2JSWZHKF@amd.com> (raw)
In-Reply-To: <dd7404b4-7f31-4189-937a-0278eb54bb2a@suse.com>
On Tue Jan 20, 2026 at 2:30 PM CET, Jan Beulich wrote:
> On 20.01.2026 14:19, Teddy Astie wrote:
>> Le 20/01/2026 à 10:56, Alejandro Vallejo a écrit :
>>> --- a/xen/arch/x86/hvm/svm/vmcb.h
>>> +++ b/xen/arch/x86/hvm/svm/vmcb.h
>>> @@ -65,6 +65,11 @@ enum GenericIntercept2bits
>>> GENERAL2_INTERCEPT_RDPRU = 1 << 14,
>>> };
>>>
>>> +/* general 2 intercepts */
>>
>> nit, you want to says general 3 intercepts
>
> And then, further nit, also get comment style right.
>
> Jan
What do you mean by comment style? it's a /* ... */ oneliner that matches
what the other general intercepts say. What am I missing?
Cheers,
Alejandro
next prev parent reply other threads:[~2026-01-21 12:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 9:53 [PATCH 0/2] x86/svm: Add support for Bus Lock Threshold Alejandro Vallejo
2026-01-20 9:53 ` [PATCH 1/2] x86/svm: Add infrastructure " Alejandro Vallejo
2026-01-20 13:12 ` Andrew Cooper
2026-01-20 13:57 ` Alejandro Vallejo
2026-01-20 13:19 ` Teddy Astie
2026-01-20 13:30 ` Jan Beulich
2026-01-21 12:40 ` Alejandro Vallejo [this message]
2026-01-21 13:07 ` Jan Beulich
2026-01-21 15:10 ` Alejandro Vallejo
2026-01-20 13:58 ` Alejandro Vallejo
2026-01-20 9:53 ` [PATCH 2/2] x86/svm: Intercept Bus Locks for HVM guests Alejandro Vallejo
2026-01-20 13:11 ` Teddy Astie
2026-01-20 13:29 ` Jan Beulich
2026-01-20 14:41 ` Alejandro Vallejo
2026-01-20 13:18 ` Andrew Cooper
2026-01-20 13:27 ` Jan Beulich
2026-01-20 13:29 ` Andrew Cooper
2026-01-20 13:34 ` Jan Beulich
2026-01-20 14:11 ` Andrew Cooper
2026-01-20 14:16 ` Jan Beulich
2026-01-20 14:26 ` Andrew Cooper
2026-01-20 14:32 ` Jan Beulich
2026-01-20 15:28 ` Alejandro Vallejo
2026-01-20 15:41 ` Alejandro Vallejo
2026-01-20 11:22 ` [PATCH 0/2] x86/svm: Add support for Bus Lock Threshold Alejandro Vallejo
2026-01-20 13:21 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFU9WAGCWK27.1UYPR2JSWZHKF@amd.com \
--to=alejandro.garciavallejo@amd.com \
--cc=andrew.cooper3@citrix.com \
--cc=jason.andryuk@amd.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=teddy.astie@vates.tech \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.