From: Alejandro Vallejo <alejandro.garciavallejo@amd.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
<xen-devel@lists.xenproject.org>
Cc: Oleksii Kurochko <oleksii.kurochko@gmail.com>,
Community Manager <community.manager@xenproject.org>
Subject: Re: [PATCH v2 3/3] CHANGELOG: Note the new SVM bus-lock intercept
Date: Thu, 22 Jan 2026 10:24:32 +0100 [thread overview]
Message-ID: <DFV0CLR7D1GE.1BY8A2Z2931GY@amd.com> (raw)
In-Reply-To: <cd1e05cf-d81c-4e19-a410-d229b68485a3@citrix.com>
On Wed Jan 21, 2026 at 7:36 PM CET, Andrew Cooper wrote:
> On 21/01/2026 2:28 pm, Alejandro Vallejo wrote:
>> Signed-off-by: Alejandro Vallejo <alejandro.garciavallejo@amd.com>
>> ---
>> CHANGELOG.md | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/CHANGELOG.md b/CHANGELOG.md
>> index 53d92a2597..07c1745f22 100644
>> --- a/CHANGELOG.md
>> +++ b/CHANGELOG.md
>> @@ -9,6 +9,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
>> ### Changed
>>
>> ### Added
>> + - On x86:
>> + - AMD bus-lock detect, used by Xen to mitigate (by rate-limiting) the
>> + system wide impact of an HVM guest misusing atomic instructions.
>>
>
> A little too much copy&paste from the SPR section. This wants
> unindenting by one level.
>
> Also, this text most importantly needs to identify which hardware the
> feature exists in. I've reworked it to:
>
> diff --git a/CHANGELOG.md b/CHANGELOG.md
> index 53d92a259731..9c3bf0411ccc 100644
> --- a/CHANGELOG.md
> +++ b/CHANGELOG.md
> @@ -9,6 +9,10 @@ The format is based on [Keep a
> Changelog](https://keepachangelog.com/en/1.0.0/)
> ### Changed
>
> ### Added
> + - On x86:
> + - Support for Bus Lock Threshold on AMD Zen5 and later CPUs, used by
> Xen to
> + mitigate (by rate-limiting) the system wide impact of an HVM guest
> + misusing atomic instructions.
>
> ### Removed
> - On x86:
>
>
> The internet suggests that it's Zen5 rather than Zen4.
>
> Also I personally put the CHANGELOG update in the commit which finally
> implements the feature, rather than doing it after the fact. This is
> more helpful when git blame-ing CHANGELOG to find things.
>
> ~Andrew
Sure, fixing up the prior patch sounds good to me.
Cheers,
Alejandro
prev parent reply other threads:[~2026-01-22 9:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 14:28 [PATCH v2 0/3] x86/svm: Add support for Bus Lock Threshold Alejandro Vallejo
2026-01-21 14:28 ` [PATCH v2 1/3] x86/svm: Add infrastructure " Alejandro Vallejo
2026-01-21 15:13 ` Alejandro Vallejo
2026-01-21 17:33 ` Andrew Cooper
2026-01-21 14:28 ` [PATCH v2 2/3] x86/svm: Intercept Bus Locks for HVM guests Alejandro Vallejo
2026-01-21 15:35 ` Andrew Cooper
2026-01-21 16:04 ` Alejandro Vallejo
2026-01-21 14:28 ` [PATCH v2 3/3] CHANGELOG: Note the new SVM bus-lock intercept Alejandro Vallejo
2026-01-21 18:36 ` Andrew Cooper
2026-01-22 9:24 ` Alejandro Vallejo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFV0CLR7D1GE.1BY8A2Z2931GY@amd.com \
--to=alejandro.garciavallejo@amd.com \
--cc=andrew.cooper3@citrix.com \
--cc=community.manager@xenproject.org \
--cc=oleksii.kurochko@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.