Re: [PATCH i-g-t v4 21/46] lib/unigraf: Introduce device configuration

["Luca Ceresoli" <luca.ceresoli@bootlin.com>]

On Mon Nov 10, 2025 at 2:39 PM CET, Louis Chauvet wrote:
> As there could be multiple devices detected by libTSI, add a configuration
> field to ensure that igt will use the proper unigraf device.
>
> The unigraf integration will search for a [Unigraf] entry containing a
> Device=
>
> For example, it can look like:
>
> [Unigraf]
> Device=UCD-500 [2434C620]
>
> Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
> ---
>  lib/unigraf/unigraf.c | 76 ++++++++++++++++++++++++++++++++++++++++++++++-----
>  1 file changed, 69 insertions(+), 7 deletions(-)
>
> diff --git a/lib/unigraf/unigraf.c b/lib/unigraf/unigraf.c
> index 55c3c445fa5e..304567467b27 100644
> --- a/lib/unigraf/unigraf.c
> +++ b/lib/unigraf/unigraf.c
> @@ -1,21 +1,16 @@
>  // SPDX-License-Identifier: MIT
>
> -#include "drmtest.h"
>  #include "glib.h"
>  #include "igt_core.h"
> -#include "igt_edid.h"
>  #include <stdint.h>
>  #include <stdio.h>
>  #include <string.h>
>  #include <time.h>
>
>  #include "unigraf.h"
> -#include "TSI.h"
>  #include "TSI_types.h"
> -#include "igt_kms.h"
> -#include "igt_pipe_crc.h"
> +#include "TSI.h"
>  #include "igt_rc.h"
> -#include "monitor_edids/monitor_edids_helper.h"

Why all these removals? Perhaps you should not include them in the first
place in patch 19?

>
>  #define unigraf_debug(fmt, ...)	igt_debug("TSI:%p: " fmt, unigraf_device, ##__VA_ARGS__)
>
> @@ -24,6 +19,19 @@ static TSI_HANDLE unigraf_device;
>  static char *unigraf_default_edid;
>  static char *unigraf_connector_name;
>
> +/**
> + * UNIGRAF_CONFIG_GROUP - Name of the unigraf group in the configuration file
> + */
> +#define UNIGRAF_CONFIG_GROUP "Unigraf"
> +/**
> + * UNIGRAF_CONFIG_DEVICE_NAME - Key of the device name in the configuration file
> + */
> +#define UNIGRAF_CONFIG_DEVICE_NAME "Device"
> +/**
> + * UNIGRAF_NAME_MAX - Maximum name length to be used for TSI functions
> + */
> +#define UNIGRAF_NAME_MAX 1024

In the next patch you move this define on top. Just define it on top here
and avoid moving it around later.

Otherwise LGTM.

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com