All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alexandre Courbot" <acourbot@nvidia.com>
To: "Zhi Wang" <zhiw@nvidia.com>
Cc: "Danilo Krummrich" <dakr@kernel.org>,
	"Alice Ryhl" <aliceryhl@google.com>,
	"Daniel Almeida" <daniel.almeida@collabora.com>,
	"Miguel Ojeda" <ojeda@kernel.org>,
	"Boqun Feng" <boqun.feng@gmail.com>,
	"Gary Guo" <gary@garyguo.net>,
	"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
	"Benno Lossin" <lossin@kernel.org>,
	"Andreas Hindborg" <a.hindborg@kernel.org>,
	"Trevor Gross" <tmgross@umich.edu>,
	"Yury Norov" <yury.norov@gmail.com>,
	"John Hubbard" <jhubbard@nvidia.com>,
	"Alistair Popple" <apopple@nvidia.com>,
	"Joel Fernandes" <joelagnelf@nvidia.com>,
	"Timur Tabi" <ttabi@nvidia.com>, "Edwin Peer" <epeer@nvidia.com>,
	"Eliot Courtney" <ecourtney@nvidia.com>,
	"Dirk Behme" <dirk.behme@de.bosch.com>,
	"Steven Price" <steven.price@arm.com>,
	rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 6/7] sample: rust: pci: use `register!` macro
Date: Wed, 28 Jan 2026 22:27:14 +0900	[thread overview]
Message-ID: <DG099OR58D58.GQL20TH2D7PQ@nvidia.com> (raw)
In-Reply-To: <20260128143522.434f75f6.zhiw@nvidia.com>

On Wed Jan 28, 2026 at 9:35 PM JST, Zhi Wang wrote:
> On Wed, 28 Jan 2026 11:37:32 +0900
> Alexandre Courbot <acourbot@nvidia.com> wrote:
>
>> Convert the direct IO accesses to properly defined registers.
>> 
>
> Tested-by: Zhi Wang <zhiw@nvidia.com>
>
> I can see the correct value of the registers read by the sample driver
> from the demesg. 

Thanks!

>
> Additionally, Clippy was complaining about unnecssary unsafe blocks and
> can be fixed by: (I haven't fully gone through the code, just applied this
> for getting rid of the warnnings.)

This is because `Bounded::__new` has become unsafe in `rust-next` ; this
is not reflected in `driver-core-next` yet, but won't appear in -rc1.


  reply	other threads:[~2026-01-28 13:29 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-28  2:37 [PATCH v4 0/7] rust: add `register!` macro Alexandre Courbot
2026-01-28  2:37 ` [PATCH v4 1/7] rust: enable the `generic_arg_infer` feature Alexandre Courbot
2026-01-28  2:37 ` [PATCH v4 2/7] rust: num: add `shr` and `shl` methods to `Bounded` Alexandre Courbot
2026-01-28 15:38   ` Gary Guo
2026-01-28  2:37 ` [PATCH v4 3/7] rust: num: add `as_bool` method to `Bounded<_, 1>` Alexandre Courbot
2026-01-28  2:37 ` [PATCH v4 4/7] rust: num: add `into_inner` method to `Bounded` Alexandre Courbot
2026-01-28 15:43   ` Gary Guo
2026-01-29  8:05     ` Alexandre Courbot
2026-01-29 20:23       ` Gary Guo
2026-01-30  0:58         ` Alexandre Courbot
2026-01-28  2:37 ` [PATCH v4 5/7] rust: io: add `register!` macro Alexandre Courbot
2026-01-28  3:02   ` John Hubbard
2026-01-28  3:47     ` Joel Fernandes
2026-01-28  7:42       ` Alexandre Courbot
2026-01-28 17:56         ` Joel Fernandes
2026-01-29 11:59           ` Alexandre Courbot
2026-01-28 16:16   ` Gary Guo
2026-01-29  8:00     ` Alexandre Courbot
2026-01-29 14:10       ` Gary Guo
2026-01-29 21:08         ` Danilo Krummrich
2026-01-30  6:55         ` Alexandre Courbot
2026-01-30 16:14           ` Gary Guo
2026-01-30 16:44             ` Danilo Krummrich
2026-01-30 17:01               ` Gary Guo
2026-01-30 17:18                 ` Danilo Krummrich
2026-01-29 12:48     ` Danilo Krummrich
2026-01-28  2:37 ` [PATCH v4 6/7] sample: rust: pci: use " Alexandre Courbot
2026-01-28 12:35   ` Zhi Wang
2026-01-28 13:27     ` Alexandre Courbot [this message]
2026-01-28 15:46       ` Gary Guo
2026-01-29  8:01         ` Alexandre Courbot
2026-01-31  1:06   ` Danilo Krummrich
2026-01-28  2:37 ` [PATCH FOR REFERENCE v4 7/7] gpu: nova-core: use the kernel " Alexandre Courbot
2026-01-28  2:57   ` John Hubbard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DG099OR58D58.GQL20TH2D7PQ@nvidia.com \
    --to=acourbot@nvidia.com \
    --cc=a.hindborg@kernel.org \
    --cc=aliceryhl@google.com \
    --cc=apopple@nvidia.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=dirk.behme@de.bosch.com \
    --cc=ecourtney@nvidia.com \
    --cc=epeer@nvidia.com \
    --cc=gary@garyguo.net \
    --cc=jhubbard@nvidia.com \
    --cc=joelagnelf@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=steven.price@arm.com \
    --cc=tmgross@umich.edu \
    --cc=ttabi@nvidia.com \
    --cc=yury.norov@gmail.com \
    --cc=zhiw@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.