All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Mahad Ibrahim" <mahad.ibrahim.dev@gmail.com>
To: "Greg KH" <gregkh@linuxfoundation.org>
Cc: <linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 4/4] staging: rtl8723bs: fix line length check
Date: Wed, 28 Jan 2026 21:09:45 +0500	[thread overview]
Message-ID: <DG0CQ4MCS7P8.2FW5L1RVCYB6L@gmail.com> (raw)
In-Reply-To: <2026012713-bovine-tricolor-d747@gregkh>

On Tue Jan 27, 2026 at 7:40 PM PKT, Greg KH wrote:
>> -		if ((cond2 & bitMask) == (driver2 & bitMask)) /*  BoardType of each RF path is matched */
>> +		/*  BoardType of each RF path is matched */
>
> Why the extra space after /* and before BoardType?
>
> thanks,
>
> greg k-h

Thank you for the review.

I included it to match the existing comment style prevalent in this
specific file. Not adding it would have caused inconsistency.

However I realize this violates the kernel coding standards.

I will send a v3 series that addresses this issue, as well as fix the
line comment style in that file as a separate logical change.

thanks,

Mahad Ibrahim


      reply	other threads:[~2026-01-28 16:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-18 11:54 [PATCH v2 0/4] staging: rtl8723bs: fix remaining checkpatch.pl Mahad Ibrahim
2026-01-18 11:54 ` [PATCH v2 1/4] staging: rtl8723bs: fix open parenthesis alignment Mahad Ibrahim
2026-01-18 11:54 ` [PATCH v2 2/4] staging: rtl8723bs: fix multiple blank line check Mahad Ibrahim
2026-01-18 11:54 ` [PATCH v2 3/4] staging: rtl8723bs: fix missing blank line after declaration Mahad Ibrahim
2026-01-18 11:54 ` [PATCH v2 4/4] staging: rtl8723bs: fix line length check Mahad Ibrahim
2026-01-27 14:40   ` Greg KH
2026-01-28 16:09     ` Mahad Ibrahim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DG0CQ4MCS7P8.2FW5L1RVCYB6L@gmail.com \
    --to=mahad.ibrahim.dev@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.