From: "Luca Ceresoli" <luca.ceresoli@bootlin.com>
To: "Felix Gu" <ustc.gu@gmail.com>,
"Paul Kocialkowski" <paulk@sys-base.io>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>
Cc: "Paul Kocialkowski" <paul.kocialkowski@bootlin.com>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/logicvc: Fix device node reference leak in logicvc_drm_config_parse()
Date: Thu, 29 Jan 2026 23:01:26 +0100 [thread overview]
Message-ID: <DG1ETXV5HGAY.IP3SL6AL640E@bootlin.com> (raw)
In-Reply-To: <20260130-logicvc_drm-v1-1-04366463750c@gmail.com>
On Thu Jan 29, 2026 at 5:21 PM CET, Felix Gu wrote:
> The logicvc_drm_config_parse() function calls of_get_child_by_name() to
> find the "layers" node but fails to release the reference, leading to a
> device node reference leak.
>
> Fix this by using the __free(device_node) cleanup attribute to automatic
> release the reference when the variable goes out of scope.
>
> Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controller")
> Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2026-01-29 22:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 16:21 [PATCH] drm/logicvc: Fix device node reference leak in logicvc_drm_config_parse() Felix Gu
2026-01-29 22:01 ` Luca Ceresoli [this message]
2026-02-03 9:57 ` Kory Maincent
2026-02-03 13:35 ` Kory Maincent
2026-02-03 17:51 ` Luca Ceresoli
2026-02-10 16:44 ` Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DG1ETXV5HGAY.IP3SL6AL640E@bootlin.com \
--to=luca.ceresoli@bootlin.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=paulk@sys-base.io \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=ustc.gu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.