Re: [OE-core][PATCH 4/4] mdadm: upgrade 4.4 -> 4.5

["Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>]

On Mon Jan 26, 2026 at 11:27 AM CET, Ankur Tyagi via lists.openembedded.org wrote:
> From: Ankur Tyagi <ankur.tyagi85@gmail.com>
>
> Changelog:
> https://git.kernel.org/pub/scm/utils/mdadm/mdadm.git/tree/CHANGELOG.md?h=mdadm-4.5
>
> Replaced 0001-restripe.c-Use-_FILE_OFFSET_BITS-to-enable-largefile.patch
> with 0001-raid6check.c-restripe.c-Use-64-bit-off_t-across-both.patch as
> partial changes from first patch are part of the upstream version[1].
>
> Dropped xmalloc.patch which is part of upstream version[2].
>
> Also refreshed other patches.
>
> [1] https://github.com/md-raid-utilities/mdadm/commit/787cc1b60130b8031be59e49d54463c58cd8cf74
> [2] https://git.kernel.org/pub/scm/utils/mdadm/mdadm.git/commit/raid6check.c?h=mdadm-4.5&id=e0df6c4c984d564e9e40913727e916a6cd8f466e
>
> Signed-off-by: Ankur Tyagi <ankur.tyagi85@gmail.com>
> ---

Hi Ankur,

Thanks for your patch.

> --- a/meta/recipes-extended/mdadm/mdadm_4.4.bb
> +++ b/meta/recipes-extended/mdadm/mdadm_4.5.bb
> @@ -13,12 +13,11 @@ SRC_URI = "git://git.kernel.org/pub/scm/utils/mdadm/mdadm.git;protocol=https;bra
>             file://0001-Fix-the-path-of-corosync-and-dlm-header-files-check.patch \
>             file://mdadm.init \
>             file://0001-Makefile-install-mdcheck.patch \
> -           file://0001-restripe.c-Use-_FILE_OFFSET_BITS-to-enable-largefile.patch \
>             file://0002-Create.c-include-linux-falloc.h-for-FALLOC_FL_ZERO_R.patch \
> -           file://xmalloc.patch \
> +           file://0001-raid6check.c-restripe.c-Use-64-bit-off_t-across-both.patch \
>             "

You should also remove the two unused patches from git.


Also, we have a second issue: I suspect this upgrade is responsible of
some intermittent reproducibility issue. I already had it twice on my
branch:

AssertionError: The following deb packages are different and not in exclusion list:
/srv/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB-extended/tmp/deploy/deb/./x86-64-v3/mdadm_4.5-r0_amd64.deb
The following ipk packages are different and not in exclusion list:
/srv/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB-extended/tmp/deploy/ipk/./x86-64-v3/mdadm_4.5-r0_x86-64-v3.ipk
The following rpm packages are different and not in exclusion list:
/srv/pokybuild/yocto-worker/reproducible/build/build-st/reproducibleB-extended/tmp/deploy/rpm/./x86_64_v3/mdadm-4.5-r0.x86_64_v3.rpm

https://autobuilder.yoctoproject.org/valkyrie/#/builders/37/builds/3278
https://autobuilder.yoctoproject.org/valkyrie/#/builders/37/builds/3274

Corresponding diffoscope output can be found here:

https://valkyrie.yocto.io/pub/repro-fail/oe-reproducible-20260129-v__phvnk/packages/diff-html/
https://valkyrie.yocto.io/pub/repro-fail/oe-reproducible-20260129-5hbi93fk/packages/diff-html/

It looks like the difference is some path that is sometimes appearing as
"BINDIR/mdadm" and sometimes as "/sbin/mdadm".

I know these reproducibility issues are not the easiest ones to debug,
but I would appreciate if you could have a look for obvious failure
reasons.

Thanks,
Mathieu

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com