From: "Ethan Tidmore" <ethantidmore06@gmail.com>
To: "Archit Anant" <architanant5@gmail.com>, <gregkh@linuxfoundation.org>
Cc: <dan.carpenter@linaro.org>, <straube.linux@gmail.com>,
<linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: rtl8723bs: use unaligned access macros in rtw_security.c
Date: Sun, 01 Feb 2026 21:43:43 -0600 [thread overview]
Message-ID: <DG45ZMYPENUQ.2DOGOIGXSC4YL@gmail.com> (raw)
In-Reply-To: <20260130075113.34666-1-architanant5@gmail.com>
On Fri Jan 30, 2026 at 1:51 AM CST, Archit Anant wrote:
> The driver defines custom functions secmicgetuint32() and
> secmicputuint32() to handle little-endian byte-to-integer conversion.
> This is redundant as the kernel provides optimized standard macros for
> this purpose in <linux/unaligned.h>.
>
> Replace the custom implementations with get_unaligned_le32() and
> put_unaligned_le32() and delete the now-unused local functions.
>
> Signed-off-by: Archit Anant <architanant5@gmail.com>
Looks good to me.
Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>
ET
prev parent reply other threads:[~2026-02-02 3:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-30 7:51 [PATCH] staging: rtl8723bs: use unaligned access macros in rtw_security.c Archit Anant
2026-02-02 3:43 ` Ethan Tidmore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DG45ZMYPENUQ.2DOGOIGXSC4YL@gmail.com \
--to=ethantidmore06@gmail.com \
--cc=architanant5@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.