From: "Danilo Krummrich" <dakr@kernel.org>
To: "Gary Guo" <gary@garyguo.net>
Cc: "Alexandre Courbot" <acourbot@nvidia.com>,
"Alice Ryhl" <aliceryhl@google.com>,
"Daniel Almeida" <daniel.almeida@collabora.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
driver-core@lists.linux.dev, rust-for-linux@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
"Zhi Wang" <zhiw@nvidia.com>, "Lyude Paul" <lyude@redhat.com>,
"Eliot Courtney" <ecourtney@nvidia.com>
Subject: Re: [PATCH 3/6] rust: io: provide Mmio relaxed ops through a wrapper type
Date: Mon, 02 Feb 2026 15:18:23 +0100 [thread overview]
Message-ID: <DG4JHKY0Y19S.24TZ7TAX5ISD@kernel.org> (raw)
In-Reply-To: <DG4J98HVOUEX.I7XOB7LPB49L@garyguo.net>
On Mon Feb 2, 2026 at 3:07 PM CET, Gary Guo wrote:
> I think ultimately choice of order to use for each I/O access is local to the
> specific access, not a global property.
>
> I know you can just do `RelaxedMmio::from(io).access()` for each single access
> too, but it feels quite verbose.
mmio.relaxed().access() would work as well.
> I guess one alternative design is explicit order on the access, e.g.
>
> io.read32(Relaxed)
>
> Or
>
> io.read32(Full)
>
> however this is verbose in some other ways... I'd like to hear how Boqun thinks
> on this one.
This apprach would be misleading for a lot of other I/O backends. For instance,
the I2C bus has no relaxed ordering.
next prev parent reply other threads:[~2026-02-02 14:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 8:12 [PATCH 0/6] rust: io: turn IoCapable into a functional trait Alexandre Courbot
2026-02-02 8:13 ` [PATCH 1/6] " Alexandre Courbot
2026-02-04 14:57 ` Daniel Almeida
2026-02-02 8:13 ` [PATCH 2/6] rust: io: mem: use non-relaxed I/O ops in examples Alexandre Courbot
2026-02-04 15:00 ` Daniel Almeida
2026-02-02 8:13 ` [PATCH 3/6] rust: io: provide Mmio relaxed ops through a wrapper type Alexandre Courbot
2026-02-02 14:07 ` Gary Guo
2026-02-02 14:18 ` Danilo Krummrich [this message]
2026-02-02 14:21 ` Danilo Krummrich
2026-02-02 14:27 ` Gary Guo
2026-02-03 22:25 ` Alexandre Courbot
2026-02-02 8:13 ` [PATCH 4/6] rust: io: remove legacy relaxed accessors of Mmio Alexandre Courbot
2026-02-04 15:19 ` Daniel Almeida
2026-02-02 8:13 ` [PATCH 5/6] rust: pci: io: remove overloaded Io methods of ConfigSpace Alexandre Courbot
2026-02-04 15:24 ` Daniel Almeida
2026-02-02 8:13 ` [PATCH 6/6] rust: io: remove overloaded Io methods of Mmio Alexandre Courbot
2026-02-04 15:58 ` Daniel Almeida
2026-02-04 10:37 ` [PATCH 0/6] rust: io: turn IoCapable into a functional trait Alice Ryhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DG4JHKY0Y19S.24TZ7TAX5ISD@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=daniel.almeida@collabora.com \
--cc=driver-core@lists.linux.dev \
--cc=ecourtney@nvidia.com \
--cc=gary@garyguo.net \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=lyude@redhat.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=zhiw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.