All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kurt Borja" <kuurtb@gmail.com>
To: "Pali Rohár" <pali@kernel.org>, "Kurt Borja" <kuurtb@gmail.com>
Cc: "Matthew Garrett" <mjg59@srcf.ucam.org>,
	"Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	"Olexa Bilaniuk" <obilaniu@gmail.com>
Subject: Re: [PATCH] platform/x86: dell-wmi: Add audio/mic mute key codes
Date: Mon, 02 Feb 2026 21:40:47 -0500	[thread overview]
Message-ID: <DG4ZA0AFOSQI.J5EJQMPYPV7K@gmail.com> (raw)
In-Reply-To: <20260202174322.x6fr4atrx5vulxt7@pali>

On Mon Feb 2, 2026 at 12:43 PM -05, Pali Rohár wrote:
> On Monday 02 February 2026 12:34:19 Kurt Borja wrote:
>> On Mon Feb 2, 2026 at 3:12 AM -05, Pali Rohár wrote:
>> > On Sunday 01 February 2026 23:37:37 Kurt Borja wrote:
>> >> Add audio/mic mute key codes found in some Alienware devices.
>> >> 
>> >> Cc: stable@vger.kernel.org
>> >> Tested-by: Olexa Bilaniuk <obilaniu@gmail.com>
>> >> Suggested-by: Olexa Bilaniuk <obilaniu@gmail.com>
>> >> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
>> >> ---
>> >>  drivers/platform/x86/dell/dell-wmi-base.c | 3 +++
>> >>  1 file changed, 3 insertions(+)
>> >> 
>> >> diff --git a/drivers/platform/x86/dell/dell-wmi-base.c b/drivers/platform/x86/dell/dell-wmi-base.c
>> >> index 28076929d6af..62cf28d1fe19 100644
>> >> --- a/drivers/platform/x86/dell/dell-wmi-base.c
>> >> +++ b/drivers/platform/x86/dell/dell-wmi-base.c
>> >> @@ -86,6 +86,9 @@ static const struct key_entry dell_wmi_keymap_type_0000[] = {
>> >>  	/* Meta key unlock */
>> >>  	{ KE_IGNORE, 0xe001, { KEY_RIGHTMETA } },
>> >>  
>> >> +	{ KE_KEY,    0x0109, { KEY_MUTE } },
>> >> +	{ KE_KEY,    0x0150, { KEY_MICMUTE } },
>> >
>> > Hello, please keep codes in the array sorted.
>> 
>> Hi Pali,
>> 
>> I thought I sorted it... I'll fix it, thanks!
>
> Before is value 0xe001 and your new values are 0x01xx. Most of values
> are 0xeXXX, so it is quite unusual that Dell allocated values with
> different pattern.

It is a bit unusual but it corresponds with the user report

	dell_wmi: Unknown key with type 0x0000 and code 0x0109 pressed
	dell_wmi: Unknown key with type 0x0000 and code 0x0150 pressed

and I also checked the acpidump.

>
> Also, could you please include into commit message for which Alienware
> devices is change needed? It would help to detect devices which will be
> fixed by your change.

Sure, the model is Alienware m18 r1 AMD.

I said "some" in the commit message because it's very likely other
Alienware models also use these codes.

>
> And please add some comment into source file above those two new codes
> for which are needed, in similar way how we have commented/documented
> other key codes.

Ack.

-- 
Thanks,
 ~ Kurt

  reply	other threads:[~2026-02-03  2:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-02  4:37 [PATCH] platform/x86: dell-wmi: Add audio/mic mute key codes Kurt Borja
2026-02-02  8:12 ` Pali Rohár
2026-02-02 17:34   ` Kurt Borja
2026-02-02 17:43     ` Pali Rohár
2026-02-03  2:40       ` Kurt Borja [this message]
2026-02-02 14:17 ` Mario Limonciello
2026-02-02 17:35   ` Kurt Borja

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DG4ZA0AFOSQI.J5EJQMPYPV7K@gmail.com \
    --to=kuurtb@gmail.com \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=obilaniu@gmail.com \
    --cc=pali@kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.