From: "Kurt Borja" <kuurtb@gmail.com>
To: "Guenter Roeck" <linux@roeck-us.net>,
"Hardware Monitoring" <linux-hwmon@vger.kernel.org>
Cc: "Armin Wolf" <W_Armin@gmx.de>, "Kurt Borja" <kuurtb@gmail.com>,
"Tinsae Tadesse" <tinsaetadesse2015@gmail.com>
Subject: Re: [PATCH] hwmon: (spd5118) Explicitly enable temperature sensor in probe function
Date: Tue, 03 Feb 2026 14:23:20 -0500 [thread overview]
Message-ID: <DG5KLLWBJEF7.2H0M48M16C4SS@gmail.com> (raw)
In-Reply-To: <20260131152048.2299403-1-linux@roeck-us.net>
On Sat Jan 31, 2026 at 10:20 AM -05, Guenter Roeck wrote:
> Instantiating the driver does not make sense if the temperature sensor
> is disabled, so enable it unconditionally in the probe function.
>
> If that fails, write operations to the chip are likely disabled
> by the I2C controller. Bail out with an error message if that happens.
Hi Guenter,
As I mentiond in the other thread, after applying this patch the probe
fails
spd5118 17-0051: error -ENXIO: Failed to enable temperature sensor (write protected ?)
spd5118 17-0053: error -ENXIO: Failed to enable temperature sensor (write protected ?)
This would be a regression in my platform because, even though the
register is write protected, I can still get temperature readings just
fine (even after the resume error).
--
Thanks,
~ Kurt
next prev parent reply other threads:[~2026-02-03 19:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-31 15:20 [PATCH] hwmon: (spd5118) Explicitly enable temperature sensor in probe function Guenter Roeck
2026-01-31 19:20 ` TINSAE TADESSE
2026-02-03 19:23 ` Kurt Borja [this message]
2026-02-03 19:49 ` Guenter Roeck
2026-02-04 6:22 ` Kurt Borja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DG5KLLWBJEF7.2H0M48M16C4SS@gmail.com \
--to=kuurtb@gmail.com \
--cc=W_Armin@gmx.de \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=tinsaetadesse2015@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.